1613377 - [wpt-sync] Sync PR 21598 - Fix outline when linebox has non-zero inline offset

Status: RESOLVED FIXED

(Core :: Layout, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 21598 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/21598
Details from upstream follow.

Koji Ishii <[e-mail]> wrote:

Fix outline when linebox has non-zero inline offset

When computing outline rects in an inline formatting context,
the coordinate system needs to be relative to the root of the
inline formatting context, because the algorithm needs to
call |LayoutObject| functions, which uses the coordinate
system for inline |LayoutObject|s.

This patch fixes not to accumulate line box offset. For the
inline direction, this is usually zero and is not visible,
but non-zero padding-left can expose this difference.

Bug: 1048070
Change-Id: I30dfabcca621136b6d78892a1856c1336c7438eb
Reviewed-on: https://chromium-review.googlesource.com/2038296
WPT-Export-Revision: d67717d5ce1239f89257595ca57e00a2f56e881d

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=876c4b6f4e9f1c46d30423c9caf69e92238c3ff3

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

FAIL: 1

Chrome

FAIL: 1

Safari

PASS: 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-ui/outline-with-padding-001.html: FAIL (Chrome: FAIL, Safari: PASS)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0ac8824f8782
[wpt PR 21598] - Fix outline when linebox has non-zero inline offset, a=testonly
https://hg.mozilla.org/integration/autoland/rev/904d477bfb8e
[wpt PR 21598] - Update wpt metadata, a=testonly

Comment 4

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/0ac8824f8782
https://hg.mozilla.org/mozilla-central/rev/904d477bfb8e