Closed Bug 1613385 Opened 4 years ago Closed 4 years ago

The "New Tab" page is wrongly scrolled down if any "Popular Topics" link is clicked for the second time in the same tab session

Categories

(Firefox :: New Tab Page, defect)

Desktop
All
defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 75
Tracking Status
firefox-esr68 --- unaffected
firefox72 --- unaffected
firefox73 --- wontfix
firefox74 + verified
firefox75 --- verified

People

(Reporter: vvalentina, Assigned: gsuntop)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

[Affected versions]:

  • Firefox 73.0 Build ID 20200203203546
  • Firefox 74.0a1 Build ID 20200205055433

[Affected Platforms]:

  • Windows 10
  • Mac 10.14
  • Linux Debian 9

[Prerequisites]:

  • Set “browser.search.region” to “US” or “CA”
  • Restart the browser

[Steps to reproduce]:

  1. Open a New Tab page.
  2. Scroll down the page until the “Popular Topics” section.
  3. Click on any of the "Popular Topics" link.
  4. Click the “Go back one page” arrow.
  5. Repeat step 3.

[Expected result]:
User is redirected to the corresponding page.

[Actual result]:
Page is scrolled down.

[Regression]:

[Additional notes]:

  • the issue is also reproduced intermittently from last row of the Recommended By Pocket section.
Attached image scroll-wrong.gif

Attaching recording for this issue.

@gsuntop could you please take a look at this?

Flags: needinfo?(gsuntop)

Tested the issue on Windows 10 x64 and Mac 10.14 and Firefox Release 72.0.2 doesn't seem to be affected. Will add the according flag.

Flags: needinfo?(gsuntop)
Attached file Bug 1613385
Assignee: nobody → gsuntop
Status: NEW → ASSIGNED
Attachment #9127358 - Attachment description: reverting 1602518 → Fixing 1613385
Attachment #9127358 - Attachment description: Fixing 1613385 → Bug 1613385
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 75

I have verified that the issue is no longer reproducible on Firefox Nightly 75.0a1 Build ID 20200220093508 using Windows 10, Mac 10.14 and Linux Ubuntu 16.04.
User is redirected to the desired popular topic page, without any scrolling issue.

Status: RESOLVED → VERIFIED

Gavin, do you think this is important enough to request an uplift to beta? Thanks

Flags: needinfo?(gsuntop)

Comment on attachment 9127358 [details]
Bug 1613385

Beta/Release Uplift Approval Request

  • User impact if declined: Users who click onto a popular topic and then back to newtab may have a subsequent popular topic link click fail.
  • Is this code covered by automated tests?: Unknown
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Small CSS change only.
  • String changes made/needed:
Flags: needinfo?(gsuntop)
Attachment #9127358 - Flags: approval-mozilla-beta?

Yeah, we probably should. Requesting uplift ^

Comment on attachment 9127358 [details]
Bug 1613385

Css change, low risk, uplift approved for 74.0b8, thanks.

Attachment #9127358 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

I have verified that the issue is no longer reproducible on Firefox Beta 74.0b8 Build ID 20200226031638 using Windows 10, Mac 10.14 and on Firefox Beta 74.0b8 Build ID 20200225150144 using Linux Mint.
User is redirected to the desired popular topic page, without any scrolling issue.

Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: