The "New Tab" page is wrongly scrolled down if any "Popular Topics" link is clicked for the second time in the same tab session
Categories
(Firefox :: New Tab Page, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr68 | --- | unaffected |
firefox72 | --- | unaffected |
firefox73 | --- | wontfix |
firefox74 | + | verified |
firefox75 | --- | verified |
People
(Reporter: vvalentina, Assigned: gsuntop)
References
(Regression)
Details
(Keywords: regression)
Attachments
(2 files)
1.94 MB,
image/gif
|
Details | |
47 bytes,
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
|
Details | Review |
[Affected versions]:
- Firefox 73.0 Build ID 20200203203546
- Firefox 74.0a1 Build ID 20200205055433
[Affected Platforms]:
- Windows 10
- Mac 10.14
- Linux Debian 9
[Prerequisites]:
- Set “browser.search.region” to “US” or “CA”
- Restart the browser
[Steps to reproduce]:
- Open a New Tab page.
- Scroll down the page until the “Popular Topics” section.
- Click on any of the "Popular Topics" link.
- Click the “Go back one page” arrow.
- Repeat step 3.
[Expected result]:
User is redirected to the corresponding page.
[Actual result]:
Page is scrolled down.
[Regression]:
- Last good revision: df1974026ae7c9c4c1bdce33be1da2fdd468e58c
- First bad revision: 090482022c3d8c79a964db0ab40e23fb937e19da
Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=df1974026ae7c9c4c1bdce33be1da2fdd468e58c&tochange=090482022c3d8c79a964db0ab40e23fb937e19da
It looks like bug 1602518 has caused this issue.
[Additional notes]:
- the issue is also reproduced intermittently from last row of the Recommended By Pocket section.
Reporter | ||
Comment 1•4 years ago
|
||
Attaching recording for this issue.
Reporter | ||
Comment 2•4 years ago
|
||
@gsuntop could you please take a look at this?
Reporter | ||
Updated•4 years ago
|
Comment 3•4 years ago
|
||
Tested the issue on Windows 10 x64 and Mac 10.14 and Firefox Release 72.0.2 doesn't seem to be affected. Will add the according flag.
Updated•4 years ago
|
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 4•4 years ago
|
||
Updated•4 years ago
|
Updated•4 years ago
|
Updated•4 years ago
|
Pushed by gsuntop@getpocket.com: https://hg.mozilla.org/integration/autoland/rev/917ee2d51c0b r=thecount
Comment 6•4 years ago
|
||
bugherder |
Reporter | ||
Comment 7•4 years ago
|
||
I have verified that the issue is no longer reproducible on Firefox Nightly 75.0a1 Build ID 20200220093508 using Windows 10, Mac 10.14 and Linux Ubuntu 16.04.
User is redirected to the desired popular topic page, without any scrolling issue.
Reporter | ||
Updated•4 years ago
|
Comment 8•4 years ago
|
||
Gavin, do you think this is important enough to request an uplift to beta? Thanks
Assignee | ||
Comment 9•4 years ago
|
||
Comment on attachment 9127358 [details]
Bug 1613385
Beta/Release Uplift Approval Request
- User impact if declined: Users who click onto a popular topic and then back to newtab may have a subsequent popular topic link click fail.
- Is this code covered by automated tests?: Unknown
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Small CSS change only.
- String changes made/needed:
Assignee | ||
Comment 10•4 years ago
|
||
Yeah, we probably should. Requesting uplift ^
Assignee | ||
Updated•4 years ago
|
Updated•4 years ago
|
Comment 11•4 years ago
|
||
Comment on attachment 9127358 [details]
Bug 1613385
Css change, low risk, uplift approved for 74.0b8, thanks.
Comment 12•4 years ago
|
||
bugherder uplift |
Reporter | ||
Comment 13•4 years ago
|
||
I have verified that the issue is no longer reproducible on Firefox Beta 74.0b8 Build ID 20200226031638 using Windows 10, Mac 10.14 and on Firefox Beta 74.0b8 Build ID 20200225150144 using Linux Mint.
User is redirected to the desired popular topic page, without any scrolling issue.
Reporter | ||
Updated•4 years ago
|
Updated•4 years ago
|
Description
•