test fixups to avoid skipping regenerating some expired certificates
Categories
(Core :: Security: PSM, enhancement, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox75 | --- | fixed |
People
(Reporter: keeler, Assigned: keeler)
References
Details
(Whiteboard: [psm-assigned])
Attachments
(1 external file)
See bug 1613275 and bug 1607845. In bug 1607845, the aim was to regenerate all test certificates that would be expiring. Unfortunately, a few were missed:
- build/pgo/certs/ certificate DBs and mochitest.client are regenerated in a different way than the rest of the certificates in bug 1607845. These would probably best be addressed by formally documenting the process of re-generating all of the certificates.
- security/manager/ssl/tests/unit/test_certDB_import/ certificates were missed by mistake. It's unclear how this happened.
- security/manager/ssl/tests/unit/test_intermediate_preloads/ were missed because there is no
test_intermediate_preloadsentry in theTEST_DIRSsection of security/manager/ssl/tests/unit/moz.build, which means that the build system never knew to re-generate those certificates, even after un-commenting-out security/manager/ssl/tests/unit/test_intermediate_preloads/moz.build - security/manager/ssl/tests/unit/test_missing_intermediate/missing-intermediate.der is DER, not PEM, and so we don't have a way to automatically re-generate it. However, it doesn't need to be DER.
| Assignee | ||
Comment 1•6 years ago
|
||
See bug 1613275 and bug 1607845. In bug 1607845, the aim was to regenerate all
test certificates that would be expiring. Unfortunately, a few were missed:
-
build/pgo/certs/ certificate DBs and mochitest.client are regenerated in a
different way than the rest of the certificates in bug 1607845. These would
probably best be addressed by formally documenting the process of
re-generating all of the certificates. -
security/manager/ssl/tests/unit/test_certDB_import/ certificates were
missed by mistake. It's unclear how this happened. -
security/manager/ssl/tests/unit/test_intermediate_preloads/ were missed
because there was no test_intermediate_preloads entry in the TEST_DIRS
section of security/manager/ssl/tests/unit/moz.build, which means that the
build system never knew to re-generate those certificates, even after
un-commenting-out the contents of
security/manager/ssl/tests/unit/test_intermediate_preloads/moz.build -
security/manager/ssl/tests/unit/test_missing_intermediate/missing-intermediate.der
was DER, not PEM, and we don't have a way to automatically re-generate DER
certificates in the same way. However, it didn't even need to be DER.
Comment 2•6 years ago
|
||
So... how do we remember to do build/pgo/certs?
Comment 4•6 years ago
|
||
Backed out changeset 9a86b638ad8a (Bug 1613422) for test_missing_intermediate.js failures
Backout link: https://hg.mozilla.org/integration/autoland/rev/c5eb0a8293b28a9a22c15a898bbd3c6aec1d154d
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=287797140&repo=autoland&lineNumber=2886
[task 2020-02-06T19:38:42.919Z] 19:38:42 INFO - TEST-START | security/manager/ssl/tests/unit/test_missing_intermediate.js
[task 2020-02-06T19:38:43.824Z] 19:38:43 WARNING - TEST-UNEXPECTED-FAIL | security/manager/ssl/tests/unit/test_missing_intermediate.js | xpcshell return code: 0
[task 2020-02-06T19:38:43.825Z] 19:38:43 INFO - TEST-INFO took 903ms
| Assignee | ||
Comment 5•6 years ago
|
||
I probably should have just fixed bug 1538980 the first time this happened.
Comment 7•6 years ago
|
||
| bugherder | ||
Description
•