1613477 - Cert exception UI in captive portal error page looks broken and doesn't work

Status: VERIFIED FIXED

(Firefox :: Security, defect, P1)

Description

[(inactive) Nihanth Subramanya [:nhnt11]]

[edited]

The "advanced" section in the captive portal error page currently looks like it's missing information, and the "accept risk and continue" button doesn't seem to do anything.

Comment 1

[:prathiksha]

Attachment: Bug 1613477 - Add relevant info to the advanced section of the captive portal page and make the buttons work. r?johannh

Comment 2

[:prathiksha]

The patch fixes -

1. Working of the "Go Back" and "Accept and Continue" buttons on the captive portal Page
2. Fills the advance section with relevant data and it doesn't look broken anymore

TO DO (filing follow-ups) -

1. Fix the layout of the captive portal page
2. Change the return button text from "Go Back (recommended)" to "Go Back"

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/006c560913f2
Add relevant info to the advanced section of the captive portal page and make the buttons work. r=johannh

Comment 5

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/006c560913f2

Comment 6

[Ethan Tseng [:ethan]]

Great work! Prathiksha, thank you for landing the patch quicly!

Comment 7

[:prathiksha]

Attachment: captive.js

A node script to test the captive portal.

Comment 8

[:prathiksha]

Adding steps to reproduce -

a) Download and run the captive.js node script (see attachment) to start a captive portal server
b) Change the captivedetect.canonicalURL pref in about:config to "http://localhost:8080"
c) Start the browser and go to "expired.badssl.com"
d) Click on the "Advanced..." button to open the advanced panel

Actual result: "Go Back(Recommended)" and "Accept Risk and Continue" buttons in the advanced panel of the error page do not work. There are no strings in the advanced panel that provide advanced technical error details and the section looks broken.

Expected results:

• The"Go Back(Recommended)" button should navigate the user to their home page
• The "Accept Risk and Continue" button should add a certificate exception and take the user to expired.badssl.com
• There should be relevant error information in the advanced panel

Comment 9

[Ciprian Georgiu, Desktop QA]

I was able to reproduce this issue with the steps provided in comment 8, using an affected Nightly build 73.0a1 from Jan.

This issue is verified fixed on latest Beta 75.0b7 running Windows 10 x64, mac 10.14 and Ubuntu 18.04 x64.