1613491 - Add some calc() infrastructure to deal with simplification, sorting

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Emilio Cobos Álvarez (:emilio)]

We're going to need a more generic simplification mechanism than what we have right now to implement min() / max() / etc. Cleanup the calc parsing code to do this simplification in the tree of expressions.

For now, we still bail out at parse time if we find an unsimplified min / max / etc in a length / length-percentage value. That is a follow-up.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1613491 - Add some calc infrastructure to deal with simplification / sorting / etc.

For now, we still bail out at the stage of getting the calc node into a
CalcLengthPercentage if we couldn't simplify the min() / max() / clamps()
involved.

After this plan is to use just CalcNode everywhere instead of
specified::CalcLengthPercentage, and then modify the computed
CalcLengthPercentage, which would look slightly different as we know all the sum
terms for those are a struct like { Length, Percentage, bool has_percentage } or
such, so all the simplification code for that becomes much simpler, ideally.

Or we could turn CalcNode generic otherwise, if it's too much code... We'll see.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1613491 - Make rust generate better code for some of the functions introduced here. r=#style

See https://github.com/rust-lang/rust/issues/68867.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6810e67ed43e
Add some calc infrastructure to deal with simplification / sorting / etc. r=heycam

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/21698 for changes under testing/web-platform/tests

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c083885bd068
Make rust generate better code for some of the functions introduced here. r=heycam

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/6810e67ed43e
https://hg.mozilla.org/mozilla-central/rev/c083885bd068

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot