Closed
Bug 1613524
Opened 4 years ago
Closed 4 years ago
Consider moving PageIconProtocolHandler into C++
Categories
(Toolkit :: Places, task)
Toolkit
Places
Tracking
()
RESOLVED
FIXED
mozilla75
| Tracking | Status | |
|---|---|---|
| firefox75 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: emilio)
References
Details
Attachments
(2 files)
Right now using it triggers JS execution for creating the channel, which is not great: we create channels in all sorts of places where JS execution is not necessarily expected.
|
Reporter | |
Comment 1•4 years ago
|
||
Once this is fixed, the workaround I am adding to nsImageBoxFrame::UpdateImage can be removed.
|
||
Comment 2•4 years ago
|
||
Could you please link the bug where you are adding the workaround?
Flags: needinfo?(bzbarsky)
|
Assignee | |
Comment 4•4 years ago
|
||
I wanted to see how hard would it be, and the answer seems "not too much".
|
||
Updated•4 years ago
|
Assignee: nobody → emilio
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 5•4 years ago
|
||
Depends on D62149
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/088ea1ae97c4 Rewrite PageIconProtocolHandler in C++ rather than Javascript. r=mak https://hg.mozilla.org/integration/autoland/rev/5aabc907cf1f Remove workaround in nsImageBoxFrame::UpdateImage. r=bzbarsky
|
||
Comment 7•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/088ea1ae97c4
https://hg.mozilla.org/mozilla-central/rev/5aabc907cf1f
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox75:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla75
You need to log in
before you can comment on or make changes to this bug.
Description
•