Closed
Bug 1613578
Opened 5 years ago
Closed 5 years ago
remove -m from command when updating a patch
Categories
(DevTools :: Documentation, task, P3)
Tracking
(firefox75 fixed)
RESOLVED
FIXED
Firefox 75
| Tracking | Status | |
|---|---|---|
| firefox75 | --- | fixed |
People
(Reporter: pranavpandey1998official, Assigned: Honza)
Details
Attachments
(1 file)
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:72.0) Gecko/20100101 Firefox/72.0
Steps to reproduce:
I am new to using phabricator so I don't know if its correct or not but I don't think -m
in line '''hg commit --amend -m 'Address revision issues: rewrite to use helper helpfulHelper()''' should be their as it will override the
existing info about the patch and make a new patch
https://searchfox.org/mozilla-central/source/devtools/docs/contributing/making-prs.md#44
|
Assignee | |
Comment 1•5 years ago
|
||
Nicolas, is this a bug in the doc?
Honza
Flags: needinfo?(nchevobbe)
|
||
Comment 2•5 years ago
|
||
it looks like so, yes, because it will override the Differential Revision: https://phabricator.services.mozilla.com/D61806 that moz-phab adds to the commit.
Flags: needinfo?(nchevobbe)
|
|
Assignee | |
Comment 3•5 years ago
|
||
|
||
Updated•5 years ago
|
Assignee: nobody → odvarko
|
||
Updated•5 years ago
|
Status: UNCONFIRMED → ASSIGNED
Type: defect → task
Ever confirmed: true
Priority: -- → P3
Pushed by jodvarko@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bfafd359ca64
remove -m from command when updating a patch r=jdescottes
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox75:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 75
You need to log in
before you can comment on or make changes to this bug.
Description
•