1613612 - Revert 1603071 - using release snippets in Nightly

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Andrei Oprea [:andreio]]

In bug 1603071 we added a pref controlled way to display release snippets in Nightly without telemetry. This was a workaround for the Nightly channel that did not have content making it easy to overlook regressions.
We can revert that bug as we now have support from the snippets backend for this.

• there will be Nightly channel specific content
• we will still replicate the Release channel content in Nightly but have && false appended to all targeting expressions
  • this is meant to replicate the overhead of selecting a snippet that would happen in release

Comment 1

[Andrei Oprea [:andreio]]

Attachment: Bug 1613612 - Revert Bug 1603071 Enable release snippets in Nightly

We now have support from the snippets backend to show content for the
Nightly channel

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c0c4c7bfe9fe
Revert Bug 1603071 Enable release snippets in Nightly r=k88hudson

Comment 3

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/c0c4c7bfe9fe

Comment 4

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (75.0a1 Build ID - 20200212093201) installed, on Windows 10 x64, Ubuntu 18.04 x64 and Mac 10.15.2. Now, the Release channel content in Nightly has the && false appended to all targeting expressions.