Closed Bug 1613645 Opened 4 years ago Closed 4 years ago

Intermittent browser/components/urlbar/tests/browser/browser_urlbar_interventions.js | Title string - "" == "Restore default settings and remove old add-ons for optimal performance."

Categories

(Firefox :: Address Bar, defect, P1)

Product:
Firefox
Component:
Address Bar
Type:
defect
Points:
1

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 74
Iteration:
74.2 - Jan 20 - Feb 09
Tracking Flags:
Tracking Status
firefox74 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: mak)

References

(Blocks 1 open bug)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Bug 1613645 - wait for translation before checking strings in urlbar interventions tests. r=adw
47 bytes, text/x-phabricator-request
Details | Review

Filed by: opoprus [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=287705086&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/Z5kpktYLQGarMsV0LIA4eQ/runs/0/artifacts/public/logs/live_backing.log

[task 2020-02-06T09:37:41.789Z] 09:37:41 INFO - TEST-START | browser/components/urlbar/tests/browser/browser_urlbar_interventions.js
[task 2020-02-06T09:37:41.969Z] 09:37:41 INFO - TEST-INFO | started process screenshot
[task 2020-02-06T09:37:42.033Z] 09:37:42 INFO - TEST-INFO | screenshot: exit 0
[task 2020-02-06T09:37:42.034Z] 09:37:42 INFO - Buffered messages logged at 09:37:41
[task 2020-02-06T09:37:42.034Z] 09:37:42 INFO - Entering test bound init
[task 2020-02-06T09:37:42.035Z] 09:37:42 INFO - TEST-PASS | browser/components/urlbar/tests/browser/browser_urlbar_interventions.js | Should be able to reset from mochitest's temporary profile once it's in the profile manager. - true == true -
[task 2020-02-06T09:37:42.035Z] 09:37:42 INFO - Leaving test bound init
[task 2020-02-06T09:37:42.035Z] 09:37:42 INFO - Entering test bound refresh
[task 2020-02-06T09:37:42.035Z] 09:37:42 INFO - TEST-PASS | browser/components/urlbar/tests/browser/browser_urlbar_interventions.js | true == true -
[task 2020-02-06T09:37:42.035Z] 09:37:42 INFO - TEST-PASS | browser/components/urlbar/tests/browser/browser_urlbar_interventions.js | 7 == 7 -
[task 2020-02-06T09:37:42.035Z] 09:37:42 INFO - TEST-PASS | browser/components/urlbar/tests/browser/browser_urlbar_interventions.js | "refresh" === "refresh" -
[task 2020-02-06T09:37:42.035Z] 09:37:42 INFO - Buffered messages finished
[task 2020-02-06T09:37:42.035Z] 09:37:42 INFO - TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/browser/browser_urlbar_interventions.js | Title string - "" == "Restore default settings and remove old add-ons for optimal performance." - JS frame :: chrome://mochitests/content/browser/browser/components/urlbar/tests/browser/head.js :: checkIntervention :: line 109
[task 2020-02-06T09:37:42.035Z] 09:37:42 INFO - Stack trace:
[task 2020-02-06T09:37:42.035Z] 09:37:42 INFO - chrome://mochitests/content/browser/browser/components/urlbar/tests/browser/head.js:checkIntervention:109
[task 2020-02-06T09:37:42.035Z] 09:37:42 INFO - chrome://mochitests/content/browser/browser/components/urlbar/tests/browser/browser_urlbar_interventions.js:refresh:33
[task 2020-02-06T09:37:42.035Z] 09:37:42 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1062
[task 2020-02-06T09:37:42.036Z] 09:37:42 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1097
[task 2020-02-06T09:37:42.036Z] 09:37:42 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:925
[task 2020-02-06T09:37:42.036Z] 09:37:42 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:808
[task 2020-02-06T09:37:42.036Z] 09:37:42 INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-02-06T09:37:42.036Z] 09:37:42 INFO - TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/browser/browser_urlbar_interventions.js | Button regexp - false == true - JS frame :: chrome://mochitests/content/browser/browser/components/urlbar/tests/browser/head.js :: checkIntervention :: line 120
[task 2020-02-06T09:37:42.036Z] 09:37:42 INFO - Stack trace:
[task 2020-02-06T09:37:42.036Z] 09:37:42 INFO - chrome://mochitests/content/browser/browser/components/urlbar/tests/browser/head.js:checkIntervention:120
[task 2020-02-06T09:37:42.036Z] 09:37:42 INFO - chrome://mochitests/content/browser/browser/components/urlbar/tests/browser/browser_urlbar_interventions.js:refresh:33
[task 2020-02-06T09:37:42.036Z] 09:37:42 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1062
[task 2020-02-06T09:37:42.036Z] 09:37:42 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1097
[task 2020-02-06T09:37:42.036Z] 09:37:42 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:925
[task 2020-02-06T09:37:42.036Z] 09:37:42 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:808
[task 2020-02-06T09:37:42.036Z] 09:37:42 INFO - TEST-PASS | browser/components/urlbar/tests/browser/browser_urlbar_interventions.js | true == true -

checkIntervention() is using straight textContent, that may not be set yet due to l10n... it should either use getDetailsOfResultAt, or await win.document.l10n.translateFragment(element);

Assignee: nobody → mak
Blocks: 1606912
Status: NEW → ASSIGNED
Iteration: --- → 74.2 - Jan 20 - Feb 09
Priority: P5 → P1
Points: --- → 1
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/66d4df827fac
wait for translation before checking strings in urlbar interventions tests. r=adw

https://hg.mozilla.org/mozilla-central/rev/66d4df827fac

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox74: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 74
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: