Closed Bug 1613659 Opened 5 years ago Closed 5 years ago

DNS over HTTPS is not disabled after rolling back the "doh-rollout.enabled" preference

Categories

(Firefox :: Security, defect, P1)

Product:
Firefox
Component:
Security
Platform:
Desktop
All
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 74
Project Flags:
Root Cause Requirement Error
Tracking Flags:
Tracking Status
firefox73 blocking verified
firefox74 + verified

People

(Reporter: ppop, Assigned: nhnt11)

References

Details

Attachments

(3 files)

doh_rollback.gif
8.82 MB, image/gif
Details
Bug 1613659 - Remove network listeners and reset TRR mode when enabled pref is rolled back. r=dragana!
47 bytes, text/x-phabricator-request
RyanVM
: approval-mozilla-release+
Details | Review
Bug 1613659 - Ensure proper rollback if no longer enabled after a restart. r=dragana!
47 bytes, text/x-phabricator-request
RyanVM
: approval-mozilla-release+
Details | Review
Attached image doh_rollback.gif —

[Affected Platforms]:

  • All Windows
  • All Mac
  • All Linux

[Affected Versions]:

  • Firefox Nightly 74.0a1, Build ID 20200205215017
  • Firefox Beta 73.0, Build ID 20200203203546

[Prerequisites]:

  • Have a profile enrolled in preference-rollout experiment that sets the "doh-rollout.enabled" to "true". (recipe 927)
  • Have the "security.content.signature.root_hash" pref set to "DB:74:CE:58:E4:F9:D0:9E:E0:42:36:BE:6C:C5:C4:F6:6A:E7:74:7D:C0:21:42:7A:03:BC:2F:57:0C:8B:9B:90".
  • Have the "app.normandy.api_url" pref set to "https://stage.normandy.nonprod.cloudops.mozgcp.net/api/v1".
  • Have the "app.normandy.dev_mode" set to "true".
  • Have the "app.normandy.logging.level" set to "0".
  • Have the "services.settings.server" set to "https://settings.stage.mozaws.net/v1".
  • Have the "ppop-doh-roll" pref set to "true".

[Steps to reproduce]:

  1. Open the browser with the profile from prerequisites.
  2. Disable the preference-rollout recipe from the Delivery Console and publish the preference-rollback recipe.
  3. Restart the browser.
  4. Navigate to about:config and observe the value of the "network.trr.mode pref".

[Expected result]:

  • The "doh-rollout.enabled" pref is removed and the doh realted preferences are cleared.

[Actual result]:

  • The "doh-rollout.enabled" pref is removed and all other doh preferences remain unchaged.

[Notes]:

  • The value of the "network.trr.mode" remains at "2" after the rollback.
  • The following Normandy recipes were used: pref-rollout and pref-rollback.
  • I have attached a screen recording of the issue:
Severity: normal → blocker

Mythmon, would it be viable to craft a Normandy recipe that does the following?

  1. Targets users who have doh-rollout.enabled=true, doh-rollout.skipHeuristicsCheck != true, doh-rollout.disable-heuristics != true
  2. Resets doh-rollout.enabled and network.trr.mode

This would effectively work as a rollback mechanism. Ideally, doh-rollout.enabled should be cleared/set to false for everyone, and network.trr.mode should be reset only if the other two pref criteria mentioned in 1. are met.

Flags: needinfo?(mcooper)

The rollback needs an extra target condition: users who were in this rollout, AND have doh-rollout.enabled=true, doh-rollout.skipHeuristicsCheck != true, doh-rollout.disable-heuristics != true

Assignee: nobody → nhnt11
Status: NEW → ASSIGNED
tracking-firefox73: --- → blocking
tracking-firefox74: --- → +
Priority: -- → P1

Mythmon, would it be viable to craft a Normandy recipe that does the following?

  1. Targets users who have doh-rollout.enabled=true, doh-rollout.skipHeuristicsCheck != true, doh-rollout.disable-heuristics != true
  2. Resets doh-rollout.enabled and network.trr.mode

This would effectively work as a rollback mechanism. Ideally, doh-rollout.enabled should be cleared/set to false for everyone, and network.trr.mode should be reset only if the other two pref criteria mentioned in 1. are met.

"Reset a pref" is not an action Normandy has in it's toolbox (nor is it really well defined in the face of Normandy rollouts).

Instead we have a rollback action. Rollback exactly undoes the change of a specific rollout, for exactly the set of users that it affected. Users that never got the rollout are unaffected, and we don't have to specially target the users of a rollout; we cast a wide net and the clients are smart. It however cannot be used "surgically". If a rollout needs undone, then we use a rollback and undo the change for all users.

To get more detailed, the way that rollout work is that every time Firefox starts, it checks for any rollouts that it has enrolled in. For any that are still relevant, it sets the prefs on the default branch. Since the default branch is not persistent, this happens again at every Firefox startup. Rollbacks interrupt this process, causing the preference to no longer be set at startup. This makes the preference revert back to it's builtin state. (There is also an immediate step that makes this not require a restart).

Flags: needinfo?(mcooper)
Pushed by nhnt11@gmail.com: https://hg.mozilla.org/integration/autoland/rev/28a9e4b075af Remove network listeners and reset TRR mode when enabled pref is rolled back. r=dragana

Backed out changeset 28a9e4b075af (Bug 1613659) for doh-rollout related failures

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=linux%2Cx64%2Casan%2Cmochitests%2Ctest-linux64-asan%2Fopt-mochitest-browser-chrome-e10s-4%2Cm%28bc4%29&fromchange=9a86b638ad8aefe8a6082877a6618bb137226ba4&tochange=df7d2d9e1042eb1216b3fae66d95e4b522914395&selectedJob=287793958

Backout link: https://hg.mozilla.org/integration/autoland/rev/df7d2d9e1042eb1216b3fae66d95e4b522914395

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=287793958&repo=autoland&lineNumber=4098

[task 2020-02-06T19:09:30.411Z] 19:09:30 INFO - TEST-START | browser/extensions/doh-rollout/test/browser/browser_rollback.js
[task 2020-02-06T19:09:48.160Z] 19:09:48 INFO - TEST-INFO | started process screentopng
[task 2020-02-06T19:09:48.603Z] 19:09:48 INFO - TEST-INFO | screentopng: exit 0
[task 2020-02-06T19:09:48.604Z] 19:09:48 INFO - Buffered messages logged at 19:09:30
[task 2020-02-06T19:09:48.604Z] 19:09:48 INFO - Entering test bound setup
[task 2020-02-06T19:09:48.604Z] 19:09:48 INFO - Leaving test bound setup
[task 2020-02-06T19:09:48.605Z] 19:09:48 INFO - Entering test bound testRollback
[task 2020-02-06T19:09:48.605Z] 19:09:48 INFO - TEST-PASS | browser/extensions/doh-rollout/test/browser/browser_rollback.js | Breadcrumb saved. -
[task 2020-02-06T19:09:48.605Z] 19:09:48 INFO - Buffered messages logged at 19:09:31
[task 2020-02-06T19:09:48.606Z] 19:09:48 INFO - TEST-PASS | browser/extensions/doh-rollout/test/browser/browser_rollback.js | Doorhanger shown pref undefined before user interaction. -
[task 2020-02-06T19:09:48.606Z] 19:09:48 INFO - TEST-PASS | browser/extensions/doh-rollout/test/browser/browser_rollback.js | TRR mode is 2 -
[task 2020-02-06T19:09:48.607Z] 19:09:48 INFO - TEST-PASS | browser/extensions/doh-rollout/test/browser/browser_rollback.js | Found the expected heuristics event. -
[task 2020-02-06T19:09:48.607Z] 19:09:48 INFO - TEST-PASS | browser/extensions/doh-rollout/test/browser/browser_rollback.js | The event records the expected decision -
[task 2020-02-06T19:09:48.608Z] 19:09:48 INFO - TEST-PASS | browser/extensions/doh-rollout/test/browser/browser_rollback.js | Got the expected reason. -
[task 2020-02-06T19:09:48.608Z] 19:09:48 INFO - TEST-PASS | browser/extensions/doh-rollout/test/browser/browser_rollback.js | Doorhanger shown pref saved. -
[task 2020-02-06T19:09:48.609Z] 19:09:48 INFO - TEST-PASS | browser/extensions/doh-rollout/test/browser/browser_rollback.js | Doorhanger decision saved. -
[task 2020-02-06T19:09:48.609Z] 19:09:48 INFO - TEST-PASS | browser/extensions/doh-rollout/test/browser/browser_rollback.js | Breadcrumb not cleared. -
[task 2020-02-06T19:09:48.609Z] 19:09:48 INFO - TEST-PASS | browser/extensions/doh-rollout/test/browser/browser_rollback.js | TRR mode is 0 -
[task 2020-02-06T19:09:48.610Z] 19:09:48 INFO - TEST-PASS | browser/extensions/doh-rollout/test/browser/browser_rollback.js | Found the expected heuristics event. -
[task 2020-02-06T19:09:48.610Z] 19:09:48 INFO - TEST-PASS | browser/extensions/doh-rollout/test/browser/browser_rollback.js | The event records the expected decision -
[task 2020-02-06T19:09:48.611Z] 19:09:48 INFO - TEST-PASS | browser/extensions/doh-rollout/test/browser/browser_rollback.js | Got the expected reason. -
[task 2020-02-06T19:09:48.611Z] 19:09:48 INFO - Buffered messages logged at 19:09:36
[task 2020-02-06T19:09:48.611Z] 19:09:48 INFO - TEST-PASS | browser/extensions/doh-rollout/test/browser/browser_rollback.js | No change in TRR mode -
[task 2020-02-06T19:09:48.612Z] 19:09:48 INFO - TEST-PASS | browser/extensions/doh-rollout/test/browser/browser_rollback.js | Found the expected heuristics event. -
[task 2020-02-06T19:09:48.612Z] 19:09:48 INFO - TEST-PASS | browser/extensions/doh-rollout/test/browser/browser_rollback.js | The event records the expected decision -
[task 2020-02-06T19:09:48.613Z] 19:09:48 INFO - TEST-PASS | browser/extensions/doh-rollout/test/browser/browser_rollback.js | Got the expected reason. -
[task 2020-02-06T19:09:48.613Z] 19:09:48 INFO - TEST-PASS | browser/extensions/doh-rollout/test/browser/browser_rollback.js | TRR mode is 0 -
[task 2020-02-06T19:09:48.614Z] 19:09:48 INFO - Buffered messages logged at 19:09:42
[task 2020-02-06T19:09:48.614Z] 19:09:48 INFO - TEST-PASS | browser/extensions/doh-rollout/test/browser/browser_rollback.js | No change in TRR mode -
[task 2020-02-06T19:09:48.614Z] 19:09:48 INFO - TEST-PASS | browser/extensions/doh-rollout/test/browser/browser_rollback.js | Found no heuristics events. -
[task 2020-02-06T19:09:48.616Z] 19:09:48 INFO - TEST-PASS | browser/extensions/doh-rollout/test/browser/browser_rollback.js | TRR mode is 2 -
[task 2020-02-06T19:09:48.616Z] 19:09:48 INFO - TEST-PASS | browser/extensions/doh-rollout/test/browser/browser_rollback.js | Found the expected heuristics event. -
[task 2020-02-06T19:09:48.617Z] 19:09:48 INFO - TEST-PASS | browser/extensions/doh-rollout/test/browser/browser_rollback.js | The event records the expected decision -
[task 2020-02-06T19:09:48.617Z] 19:09:48 INFO - TEST-PASS | browser/extensions/doh-rollout/test/browser/browser_rollback.js | Got the expected reason. -
[task 2020-02-06T19:09:48.618Z] 19:09:48 INFO - TEST-PASS | browser/extensions/doh-rollout/test/browser/browser_rollback.js | TRR mode is 0 -
[task 2020-02-06T19:09:48.618Z] 19:09:48 INFO - TEST-PASS | browser/extensions/doh-rollout/test/browser/browser_rollback.js | Found the expected heuristics event. -
[task 2020-02-06T19:09:48.618Z] 19:09:48 INFO - TEST-PASS | browser/extensions/doh-rollout/test/browser/browser_rollback.js | The event records the expected decision -
[task 2020-02-06T19:09:48.619Z] 19:09:48 INFO - TEST-PASS | browser/extensions/doh-rollout/test/browser/browser_rollback.js | Got the expected reason. -
[task 2020-02-06T19:09:48.619Z] 19:09:48 INFO - TEST-PASS | browser/extensions/doh-rollout/test/browser/browser_rollback.js | TRR mode is 0 -
[task 2020-02-06T19:09:48.620Z] 19:09:48 INFO - Buffered messages logged at 19:09:47
[task 2020-02-06T19:09:48.620Z] 19:09:48 INFO - TEST-PASS | browser/extensions/doh-rollout/test/browser/browser_rollback.js | No change in TRR mode -
[task 2020-02-06T19:09:48.623Z] 19:09:48 INFO - TEST-PASS | browser/extensions/doh-rollout/test/browser/browser_rollback.js | Found no heuristics events. -
[task 2020-02-06T19:09:48.623Z] 19:09:48 INFO - Buffered messages logged at 19:09:48
[task 2020-02-06T19:09:48.624Z] 19:09:48 INFO - TEST-PASS | browser/extensions/doh-rollout/test/browser/browser_rollback.js | TRR mode is 0 -
[task 2020-02-06T19:09:48.625Z] 19:09:48 INFO - Buffered messages finished
[task 2020-02-06T19:09:48.625Z] 19:09:48 INFO - TEST-UNEXPECTED-FAIL | browser/extensions/doh-rollout/test/browser/browser_rollback.js | Found the expected heuristics event. - Got 0, expected 1
[task 2020-02-06T19:09:48.626Z] 19:09:48 INFO - Stack trace:
[task 2020-02-06T19:09:48.626Z] 19:09:48 INFO - chrome://mochikit/content/browser-test.js:test_is:1320
[task 2020-02-06T19:09:48.626Z] 19:09:48 INFO - chrome://mochitests/content/browser/browser/extensions/doh-rollout/test/browser/head.js:checkHeuristicsTelemetry:92
[task 2020-02-06T19:09:48.627Z] 19:09:48 INFO - chrome://mochitests/content/browser/browser/extensions/doh-rollout/test/browser/browser_rollback.js:testRollback:96
[task 2020-02-06T19:09:48.627Z] 19:09:48 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1062
[task 2020-02-06T19:09:48.627Z] 19:09:48 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1097
[task 2020-02-06T19:09:48.627Z] 19:09:48 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:925
[task 2020-02-06T19:09:48.628Z] 19:09:48 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:808
[task 2020-02-06T19:09:48.628Z] 19:09:48 INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-02-06T19:09:48.629Z] 19:09:48 INFO - TEST-UNEXPECTED-FAIL | browser/extensions/doh-rollout/test/browser/browser_rollback.js | Uncaught exception - at chrome://mochitests/content/browser/browser/extensions/doh-rollout/test/browser/head.js:93 - TypeError: can't access property 4, events[0] is undefined
[task 2020-02-06T19:09:48.629Z] 19:09:48 INFO - Stack trace:
[task 2020-02-06T19:09:48.629Z] 19:09:48 INFO - checkHeuristicsTelemetry@chrome://mochitests/content/browser/browser/extensions/doh-rollout/test/browser/head.js:93:3
[task 2020-02-06T19:09:48.630Z] 19:09:48 INFO - asynctestRollback@chrome://mochitests/content/browser/browser/extensions/doh-rollout/test/browser/browser_rollback.js:96:9
[task 2020-02-06T19:09:48.630Z] 19:09:48 INFO - AsyncTester_execTest/<@chrome://mochikit/content/browser-test.js:1062:34
[task 2020-02-06T19:09:48.630Z] 19:09:48 INFO - asyncTester_execTest@chrome://mochikit/content/browser-test.js:1097:11
[task 2020-02-06T19:09:48.630Z] 19:09:48 INFO - nextTest/<@chrome://mochikit/content/browser-test.js:925:14
[task 2020-02-06T19:09:48.631Z] 19:09:48 INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:808:67
[task 2020-02-06T19:09:48.631Z] 19:09:48 INFO - Leaving test bound testRollback
[task 2020-02-06T19:09:48.632Z] 19:09:48 INFO - Console message: [JavaScript Error: "WebExtension context not found!" {file: "resource://gre/modules/ExtensionParent.jsm" line: 1210}]
[task 2020-02-06T19:09:48.633Z] 19:09:48 INFO - getContextById@resource://gre/modules/ExtensionParent.jsm:1210:13
[task 2020-02-06T19:09:48.633Z] 19:09:48 INFO - recvAPICall@resource://gre/modules/ExtensionParent.jsm:1078:24
[task 2020-02-06T19:09:48.634Z] 19:09:48 INFO - _recv@resource://gre/modules/ConduitsChild.jsm:78:20
[task 2020-02-06T19:09:48.634Z] 19:09:48 INFO - receiveMessage@resource://gre/modules/ConduitsParent.jsm:283:20
[task 2020-02-06T19:09:48.634Z] 19:09:48 INFO - JSWindowActor query_send@resource://gre/modules/ConduitsChild.jsm:63:11
[task 2020-02-06T19:09:48.635Z] 19:09:48 INFO - _send@resource://gre/modules/ConduitsChild.jsm:111:18
[task 2020-02-06T19:09:48.635Z] 19:09:48 INFO - callParentAsyncFunction@resource://gre/modules/ExtensionChild.jsm:1332:18
[task 2020-02-06T19:09:48.636Z] 19:09:48 INFO - callAsyncFunction@resource://gre/modules/ExtensionChild.jsm:1098:33
[task 2020-02-06T19:09:48.636Z] 19:09:48 INFO - stub@resource://gre/modules/Schemas.jsm:2683:30
[task 2020-02-06T19:09:48.636Z] 19:09:48 INFO - shouldRunHeuristics@moz-extension://483045ca-c34d-4a1f-89c8-33a112dac130/background.js:140:57
[task 2020-02-06T19:09:48.637Z] 19:09:48 INFO - asyncheuristics@moz-extension://483045ca-c34d-4a1f-89c8-33a112dac130/background.js:271:50
[task 2020-02-06T19:09:48.637Z] 19:09:48 INFO - init@moz-extension://483045ca-c34d-4a1f-89c8-33a112dac130/background.js:523:21
[task 2020-02-06T19:09:48.637Z] 19:09:48 INFO - asyncstart@moz-extension://483045ca-c34d-4a1f-89c8-33a112dac130/background.js:618:15
[task 2020-02-06T19:09:48.638Z] 19:09:48 INFO - async*@moz-extension://483045ca-c34d-4a1f-89c8-33a112dac130/background.js:629:11
[task 2020-02-06T19:09:48.638Z] 19:09:48 INFO - AsyncapplySafeWithoutClone@resource://gre/modules/ExtensionCommon.jsm:614:24
[task 2020-02-06T19:09:48.639Z] 19:09:48 INFO - fire@resource://gre/modules/ExtensionChild.jsm:1279:37
[task 2020-02-06T19:09:48.639Z] 19:09:48 INFO - recvRunListener@resource://gre/modules/ExtensionChild.jsm:1283:13
[task 2020-02-06T19:09:48.639Z] 19:09:48 INFO - _recv@resource://gre/modules/ConduitsChild.jsm:78:20
[task 2020-02-06T19:09:48.640Z] 19:09:48 INFO - receiveMessage@resource://gre/modules/ConduitsChild.jsm:169:20
[task 2020-02-06T19:09:48.640Z] 19:09:48 INFO - JSWindowActor query_send@resource://gre/modules/ConduitsChild.jsm:61:20
[task 2020-02-06T19:09:48.641Z] 19:09:48 INFO - _send@resource://gre/modules/ConduitsParent.jsm:206:18
[task 2020-02-06T19:09:48.641Z] 19:09:48 INFO - listener@resource://gre/modules/ExtensionParent.jsm:1149:39
[task 2020-02-06T19:09:48.642Z] 19:09:48 INFO - applySafeWithoutClone@resource://gre/modules/ExtensionCommon.jsm:614:24
[task 2020-02-06T19:09:48.642Z] 19:09:48 INFO - applySafe@resource://gre/modules/ExtensionParent.jsm:756:17
[task 2020-02-06T19:09:48.643Z] 19:09:48 INFO - addListener/async/<@resource://gre/modules/ExtensionCommon.jsm:2440:39
[task 2020-02-06T19:09:48.643Z] 19:09:48 INFO - promise callbackasync@resource://gre/modules/ExtensionCommon.jsm:2438:34
[task 2020-02-06T19:09:48.644Z] 19:09:48 INFO - observer@jar:file:///builds/worker/workspace/build/application/firefox/browser/features/doh-rollout@mozilla.org.xpi!/experiments/preferences/api.js:46:22
[task 2020-02-06T19:09:48.645Z] 19:09:48 INFO - Preferences._set@resource://gre/modules/Preferences.jsm:160:24
[task 2020-02-06T19:09:48.645Z] 19:09:48 INFO - Preferences.set@resource://gre/modules/Preferences.jsm:115:8
[task 2020-02-06T19:09:48.646Z] 19:09:48 INFO - testRollback@chrome://mochitests/content/browser/browser/extensions/doh-rollout/test/browser/browser_rollback.js:93:15
[task 2020-02-06T19:09:48.646Z] 19:09:48 INFO - AsyncTester_execTest/<@chrome://mochikit/content/browser-test.js:1062:34
[task 2020-02-06T19:09:48.647Z] 19:09:48 INFO - async*Tester_execTest@chrome://mochikit/content/browser-test.js:1097:11
[task 2020-02-06T19:09:48.647Z] 19:09:48 INFO - nextTest/<@chrome://mochikit/content/browser-test.js:925:14
[task 2020-02-06T19:09:48.647Z] 19:09:48 INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:808:67
[task 2020-02-06T19:09:48.648Z] 19:09:48 INFO -
[task 2020-02-06T19:09:48.648Z] 19:09:48 INFO - GECKO(4026) | MEMORY STAT | vsize 20975040MB | residentFast 1036MB
[task 2020-02-06T19:09:48.649Z] 19:09:48 INFO - TEST-OK | browser/extensions/doh-rollout/test/browser/browser_rollback.js | took 18065ms

Flags: needinfo?(nhnt11)

Also seeing related xpcshell failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=xpcshell-e10s&fromchange=9a86b638ad8aefe8a6082877a6618bb137226ba4&selectedJob=287797063

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=287797063&repo=autoland&lineNumber=4717

[task 2020-02-06T19:44:49.806Z] 19:44:49 INFO - TEST-START | browser/extensions/doh-rollout/test/unit/test_localStorageMigration.js
[task 2020-02-06T19:49:49.952Z] 19:49:49 WARNING - TEST-UNEXPECTED-TIMEOUT | browser/extensions/doh-rollout/test/unit/test_localStorageMigration.js | Test timed out
[task 2020-02-06T19:49:49.953Z] 19:49:49 INFO - TEST-INFO took 300145ms

Component: Shield Study → Security
Flags: needinfo?(nhnt11)
Product: Shield → Firefox
Version: unspecified → Trunk

Comment on attachment 9124771 [details]
Bug 1613659 - Remove network listeners and reset TRR mode when enabled pref is rolled back. r=dragana!

Beta/Release Uplift Approval Request

  • User impact if declined: When we rollout DoH, we don't have a reliable way to roll it back if there's a problem.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: With the patch, after clearing or flipping doh-rollout.enabled to false, TRR mode will be reset to 0 and heuristics will not be run again upon network changes. When flipped back to true, heuristics will be run again and TRR mode will change to 2 if the heuristics pass.

Note that if the heuristics were already disabled due to enterprise policy or pre-existing user value, this is respected and TRR mode should not be reset to 0 when doh-rollout.enabled is cleared or set to false.

  • List of other uplifts needed: None
  • Risk to taking this patch: Medium
  • Why is the change risky/not risky? (and alternatives if risky): It's a small-ish change, but it's not insignificant. It is covered by automated tests. QA will be testing this as well.
  • String changes made/needed:
Attachment #9124771 - Flags: approval-mozilla-release?
Flags: qe-verify+
Pushed by nhnt11@gmail.com: https://hg.mozilla.org/integration/autoland/rev/3a02cc6f98ea Remove network listeners and reset TRR mode when enabled pref is rolled back. r=dragana

Comment on attachment 9124771 [details]
Bug 1613659 - Remove network listeners and reset TRR mode when enabled pref is rolled back. r=dragana!

Blocks the DoH rollout. Approved for 73.0 RC2.

Attachment #9124771 - Flags: approval-mozilla-release? → approval-mozilla-release+

https://hg.mozilla.org/mozilla-central/rev/3a02cc6f98ea

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox74: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 74
QA Whiteboard: [qa-triaged]
Regressions: 1613866

I have retested this issue and it is still reproducible. Removing the "doh-rollout.enabled" preference using a Normandy preference-rollback recipe does not reset the "network.trr.mode" preference to "0". Manually flipping the preference to "false" causes the value of the "network.trr.mode" preference to change correctly. Tested using Firefox Beta 73.0 on Windows 10 x64 and macOS 10.15.2.

Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Flags: needinfo?(nhnt11)
Pushed by nhnt11@gmail.com: https://hg.mozilla.org/integration/autoland/rev/882200a11bcf Ensure proper rollback if no longer enabled after a restart. r=dragana
Status: REOPENED → ASSIGNED
status-firefox73: fixed → affected
status-firefox74: fixed → affected
Regressions: 1613994

Comment on attachment 9125034 [details]
Bug 1613659 - Ensure proper rollback if no longer enabled after a restart. r=dragana!

Carrying over the previous release approval for this.

Attachment #9125034 - Flags: approval-mozilla-release+

https://hg.mozilla.org/mozilla-central/rev/882200a11bcf

Status: ASSIGNED → RESOLVED
Closed: 5 years ago → 5 years ago
status-firefox74: affected → fixed
Resolution: --- → FIXED

I have verified that this issue is no longer reproducible. The "network.trr.mode" pref correctly changes to "0" after executing a preference-rollback recipe on the "doh-rollout.enabled" pref. Tested using Firefox Nightly 74.0a1 (Build ID 20200209215935) and Beta 73.0 (Build ID 20200207195153) on Windows 10 x64, macOS 10.15.2 and Ubuntu 18.

Status: RESOLVED → VERIFIED
status-firefox73: fixed → verified
status-firefox74: fixed → verified
Flags: needinfo?(nhnt11)

Please specify a root cause for this bug. See :tmaity for more information.

Root Cause: --- → ?
Root Cause: ? → Requirement Error
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: