Closed Bug 1613662 Opened 4 years ago Closed 4 years ago

Search Tip delay can interfere with typing

Categories

(Firefox :: Address Bar, defect, P1)

defect
Points:
1

Tracking

()

VERIFIED FIXED
Firefox 74
Iteration:
74.2 - Jan 20 - Feb 09
Tracking Status
firefox74 --- verified

People

(Reporter: bugzilla, Assigned: bugzilla)

References

Details

Attachments

(1 file)

Search Tips are only shown after a 200ms delay. If a user opens a page and quickly starts typing, their query will be deleted after 200ms when the Search Tip calls search(""). This is made worse because the user continuing to type is enough to dismiss the tip, so it just flashes on screen for a moment.

we should have canceled the previous query when the user starts typing, doesn't the tips provider check if the query was canceled?

Priority: -- → P1

We do, but we don't make the same check in _maybeShowTipForUrl, which is where we call search(""). Afaict, we can remove the timeout entirely. It was in the experiment because we didn't have fine control over when the search tips provider was called, so URLBarSetURI could be called in the middle of the experiment's logic and reset the Urlbar value. Now we can be sure we're running after URLBarSetURI so the timeout isn't needed.

Assignee: nobody → htwyford
Status: NEW → ASSIGNED
Iteration: --- → 74.2 - Jan 20 - Feb 09
Points: 2 → 1
Pushed by htwyford@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/27170e9fd98b
Remove timeout from UrlbarProviderSearchTips. r=adw
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 74
Flags: qe-verify+

I have reproduced this issue using Firefox 74.0a1 (2020.02.06) on Win 8.1 x64.
I can confirm this issue is fixed, I verified using Firefox 74.0b9 on Win 8.1 x64, macOS 10.13 and Ubuntu 18.04 x64.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: