1613662 - Search Tip delay can interfere with typing

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Harry Twyford]

Search Tips are only shown after a 200ms delay. If a user opens a page and quickly starts typing, their query will be deleted after 200ms when the Search Tip calls search(""). This is made worse because the user continuing to type is enough to dismiss the tip, so it just flashes on screen for a moment.

Comment 1

[Marco Bonardo [:mak]]

we should have canceled the previous query when the user starts typing, doesn't the tips provider check if the query was canceled?

Comment 2

[Harry Twyford]

We do, but we don't make the same check in _maybeShowTipForUrl, which is where we call search(""). Afaict, we can remove the timeout entirely. It was in the experiment because we didn't have fine control over when the search tips provider was called, so URLBarSetURI could be called in the middle of the experiment's logic and reset the Urlbar value. Now we can be sure we're running after URLBarSetURI so the timeout isn't needed.

Comment 3

[Harry Twyford]

Attachment: Bug 1613662 - Remove timeout from UrlbarProviderSearchTips. r?adw!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/27170e9fd98b
Remove timeout from UrlbarProviderSearchTips. r=adw

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/27170e9fd98b

Comment 6

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

I have reproduced this issue using Firefox 74.0a1 (2020.02.06) on Win 8.1 x64.
I can confirm this issue is fixed, I verified using Firefox 74.0b9 on Win 8.1 x64, macOS 10.13 and Ubuntu 18.04 x64.