1613668 - Split console is missing filter buttons

Status: VERIFIED FIXED

(DevTools :: Console, defect, P1)

Description

[Nicolas Chevobbe [:nchevobbe]]

Steps to reproduce

1. Open the netmonitor
2. Make sure the devtools window is wide enough
3. Hit <kbd>Esc</kbd> to get the split console

Expected results

Everything is like in regular console

Actual results

The console is missing its filter buttons

---

When narrowing down the window, the filter buttons will appear in their own toolbar, as expected.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Bug 1612913 didn't accounted for the button to close the split console, which is messing up with the grid

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1613668 - Fix filterbar in split console. r=Honza.

The filterbar grid should only have subgrid for grid-template-rows,
not columns, as we want it to have its own column (1 for the main
ui elements, and another one for the close button).

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/faedb240e8bc
Fix filterbar in split console. r=Honza.

Comment 4

[:Harald Kirschner :digitarald]

[Tracking Requested - why for this release]: Broken split console for DevTools power users.

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/faedb240e8bc

Comment 6

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 9124786 [details]
Bug 1613668 - Fix filterbar in split console. r=Honza.

Beta/Release Uplift Approval Request

• User impact if declined: broken filterbar in devtools split webconsole
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. Open the inspector on any page

1. Hit Esc to open split console
2. Ensure the filter buttons are visible

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): DevTools CSS only patch, fixes CSS grid layout
• String changes made/needed:

Comment 7

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9124786 [details]
Bug 1613668 - Fix filterbar in split console. r=Honza.

CSS only fix, low risk, uplift approved for 74.0b3, thanks

Comment 8

[Alin Ilea, Desktop QA]

Reproduced the initial issue using an old Beta build 74.0b1 (Build id: 20200210140608).
Verified - Fixed in latest Nightly 75.0a1 (Build id: 20200211215452) using Windows 10, Mac OS 10.15 and Ubuntu 18.04.

Comment 9

[Dorel Luca [:dluca]]

https://hg.mozilla.org/releases/mozilla-beta/rev/c424b9d1a5ea

Comment 10

[Alin Ilea, Desktop QA]

Verified - Fixed in latest Beta 74.0b3 (Build id: 20200214015126) using Windows 10, Mac OS 10.15 and Ubuntu 18.04.