1613731 - Context Menu: Move the Fill Login/Password menu item to the top of the context menu

Status: VERIFIED FIXED

(Toolkit :: Password Manager, enhancement, P1)

Description

[Matthew N. [:MattN]]

Bug 1595915 moved the generation option to the top but now it's far from the Fill Login/Password item which is not great. Katie wants the Fill menu item first followed by the generation option.

Jared, is this something you can try land before the merge (today/tomorrow)?

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Yes, I can try to get to this today.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1613731 - Move the 'fill login' menuitem up to the top of the context menu. r?MattN

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f15513c3ad0e
Move the 'fill login' menuitem up to the top of the context menu. r=MattN

Comment 4

[Razvan Maries]

Backed out for Mochitest perma failures.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&searchStr=linux%2Cx64%2Cdebug%2Cmochitests%2Cwith%2Cfission%2Cenabled%2Ctest-linux64%2Fdebug-mochitest-browser-chrome-fis-e10s-12%2Cm-fis%28bc12%29&revision=f15513c3ad0e8bb898ae2f5d739eb03dce2467e9&selectedJob=287959312

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=287959312&repo=autoland&lineNumber=21279

Backout: https://hg.mozilla.org/integration/autoland/rev/9c9df438d6208ebb190d02ae7d5478e460e818e4

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4b5bee9c28ab
Move the 'fill login' menuitem up to the top of the context menu. r=MattN

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/4b5bee9c28ab

Comment 7

[Oana Botisan, Desktop QA]

I managed to reproduce the issue on an older version of Nightly (2020-02-06).
I verified the fix using latest Nightly 74.0a1 on Windows 10 x64, Ubuntu 18.04 x64 and macOS 10.15. The issue is not reproducing anymore. The option is at the top of the context menu.