Closed
Bug 1613732
Opened 4 years ago
Closed 4 years ago
Revise ReflowChildFlags comments, and use logical ReflowChild and FinishReflowChild in flex container
Categories
(Core :: Layout: Flexbox, task, P3)
Core
Layout: Flexbox
Tracking
()
RESOLVED
FIXED
mozilla74
| Tracking | Status | |
|---|---|---|
| firefox74 | --- | fixed |
People
(Reporter: TYLin, Assigned: TYLin)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
No description provided.
|
Assignee | |
Comment 1•4 years ago
|
||
The entire comment deleted in nsContainerFrame.cpp belongs to
FinishReflowChild(), which is already documented in the header.
|
|
Assignee | |
Comment 2•4 years ago
|
||
This bit is set, but no function uses it.
Depends on D61885
|
|
Assignee | |
Comment 3•4 years ago
|
||
Depends on D61886
|
||
Updated•4 years ago
|
Assignee: nobody → aethanyc
Status: NEW → ASSIGNED
|
|
||
Updated•4 years ago
|
Attachment #9124824 -
Attachment description: Bug 1613732 Part 1 - Revise document for ReflowChildFlags, ReflowChild(), and FinishReflowChild(). → Bug 1613732 Part 1 - Revise documentation for ReflowChildFlags, ReflowChild(), and FinishReflowChild().
|
|
||
Updated•4 years ago
|
Attachment #9124826 -
Attachment description: Bug 1613732 Part 3 - Use logical ReflowChild() and FinishReflowChild() in flex container. → Bug 1613732 Part 3 - Use logical ReflowChild() and FinishReflowChild() to do "measuring reflow" of flex items.
Pushed by aethanyc@gmail.com: https://hg.mozilla.org/integration/autoland/rev/8cf27edd83b2 Part 1 - Revise documentation for ReflowChildFlags, ReflowChild(), and FinishReflowChild(). r=dholbert https://hg.mozilla.org/integration/autoland/rev/bb6a13482426 Part 2 - Remove unused ReflowChildFlags::NoVisibility. r=dholbert https://hg.mozilla.org/integration/autoland/rev/0b8f336109ab Part 3 - Use logical ReflowChild() and FinishReflowChild() to do "measuring reflow" of flex items. r=dholbert
|
||
Comment 5•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/8cf27edd83b2
https://hg.mozilla.org/mozilla-central/rev/bb6a13482426
https://hg.mozilla.org/mozilla-central/rev/0b8f336109ab
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox74:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
You need to log in
before you can comment on or make changes to this bug.
Description
•