1613732 - Revise ReflowChildFlags comments, and use logical ReflowChild and FinishReflowChild in flex container

Status: RESOLVED FIXED

(Core :: Layout: Flexbox, task, P3)

Comment 1

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1613732 Part 1 - Revise documentation for ReflowChildFlags, ReflowChild(), and FinishReflowChild().

The entire comment deleted in nsContainerFrame.cpp belongs to
FinishReflowChild(), which is already documented in the header.

Comment 2

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1613732 Part 2 - Remove unused ReflowChildFlags::NoVisibility.

This bit is set, but no function uses it.

Depends on D61885

Comment 3

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1613732 Part 3 - Use logical ReflowChild() and FinishReflowChild() to do "measuring reflow" of flex items.

Depends on D61886

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8cf27edd83b2
Part 1 - Revise documentation for ReflowChildFlags, ReflowChild(), and FinishReflowChild(). r=dholbert
https://hg.mozilla.org/integration/autoland/rev/bb6a13482426
Part 2 - Remove unused ReflowChildFlags::NoVisibility. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/0b8f336109ab
Part 3 - Use logical ReflowChild() and FinishReflowChild() to do "measuring reflow" of flex items. r=dholbert

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/8cf27edd83b2
https://hg.mozilla.org/mozilla-central/rev/bb6a13482426
https://hg.mozilla.org/mozilla-central/rev/0b8f336109ab