1613773 - Merge devtools.inspector.showUserAgentShadowRoots into devtools.inspector.showAllAnonymousContent

Status: RESOLVED FIXED

(DevTools :: Inspector, task, P3)

Description

[Julian Descottes [:jdescottes]]

We currently have two preferences that control showing anonymous/user-agent content in the inspector:

• devtools.inspector.showUserAgentShadowRoots
• devtools.inspector.showAllAnonymousContent

Splitting them makes sense from a technical standpoint, but from a user point of view they serve the same purpose. Let's first fold showUserAgentShadowRoots into devtools.inspector.showAllAnonymousContent. The showAllAnonymousContent preference is automatically set for the Browser Toolbox, which means that Browser Toolbox users will automatically start seeing user agent shadow roots after this change.

We could also rename the preference to stop referring to "anonymous" (ua shadow roots are not anonymous content), and maybe expose a setting the in the DevTools options panel.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1613773 - Merge devtools.inspector.showUserAgentShadowRoots into devtools.inspector.showAllAnonymousContent

Comment 2

[:Gijs (he/him)]

Thanks for jumping on this - is the patch here ready for review? :-)

Comment 3

[Julian Descottes [:jdescottes]]

Thanks for pinging me, I forgot to assign a reviewer! :)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f02a7d6551df
Merge devtools.inspector.showUserAgentShadowRoots into devtools.inspector.showAllAnonymousContent r=rcaliman

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/f02a7d6551df