161387 - Patch: Improved label truncating for tabs

Status: VERIFIED FIXED

(Camino Graveyard :: Tabbed Browsing, enhancement)

Description

[Max Horn]

This patch implemented improved truncating for overlong tab labels in Chimera by taking 
into account the real character widths.

Comment 1

[Max Horn]

Attachment: The patch

Comment 2

[Max Horn]

Attachment: Tab label truncation w/o the patch

Comment 3

[Max Horn]

Attachment: Tab label truncation with the patch

Comment 4

[Winnie Lam]

patch available - cc: pinkerton

Comment 5

[Mike Pinkerton (not reading bugmail)]

-> simon for a look

Comment 6

[Simon Fraser [no longer active]]

Comment on attachment 94265 [details] [diff] [review]
The patch

In discussion with Max, the code needs work.

Comment 7

[Max Horn]

Attachment: Improved patch

As discussed on IRC, here's a new improved patch. Besides optimizing the
truncate method, it also works around a speed barrier in NSTabViewItem: for
very long labels, it will cause extreme slow down - since we were basically
doing everything label related ourselves anyway, I simply don't pass the label
thru to the super class anymore. Also, the truncated string is cached.

In total, Chimera now is a lot *faster* for pages with very long titles than it
used to be (e.g. loading an otherwise empty page with a 300 char title into a
tab is now instant, whereas it used to take 2-3 secs over here to display).

Comment 8

[Max Horn]

Gah, there is a small redrawing problem now. Seems that the tab view system relays on 
setLabel being called. There is a simple fix, luckily: in my custom setLabel method, insert 
this inside the if:

    [super setLabel:@"foo"];

@"foo" is just random, it doesn't matter what text we pass (as long as it is short, long text 
will cause slowdowns again). With that, all works perfect, as far as I can tell.

Comment 9

[Max Horn]

Are there any issues left with this Simon? I only ask because from a 
discussion on IRC last week or so I had the impression you were trying 
my latest patch, but since then nothing happend. If there are any issues, 
please tell me so that I can fix 'em, but if you just had no time so far that's 
alright of course :-)

Comment 10

[Simon Fraser [no longer active]]

Sorry, just haven't had the cycles to test it and check in.

Comment 11

[Simon Fraser [no longer active]]

This patch breaks setting the label on tabs, even if I call [super setLabel:@"foo"];

Comment 12

[Simon Fraser [no longer active]]

Attachment: testcase that changes the page title

Comment 13

[Simon Fraser [no longer active]]

The tab updating issue was my own. Ignore me  ;)

Comment 14

[Simon Fraser [no longer active]]

Patch has been checked in.

Comment 15

[sairuh (rarely reading bugmail)]

vrfy'd fixed using 2002.11.19.11 on 10.2.2.