1613889 - Update sctp library from upstream

Status: RESOLVED DUPLICATE of bug 1646715

(Core :: WebRTC: Networking, defect, P2)

Description

[Dan Minor [:dminor]]

We haven't done an sctp upstream update since Bug 1297418, which landed in 2017. We've only been cherry picking fixes since then. We should plan on doing a full update.

Comment 1

[Michael Tüxen]

Please wait a couple of days since we are fixing a deadlock bug, which was introduced when we fixed a crash reported by Mozilla recently. The fix turned the crash into a deadlock in some cases. Here is the PR currently being worked on: https://github.com/sctplab/usrsctp/pull/417

I will let you know in this bug report when I think is a good point of time to update the sources.

Comment 2

[Dan Minor [:dminor]]

(In reply to Michael Tüxen from comment #1)

Please wait a couple of days since we are fixing a deadlock bug, which was introduced when we fixed a crash reported by Mozilla recently. The fix turned the crash into a deadlock in some cases. Here is the PR currently being worked on: https://github.com/sctplab/usrsctp/pull/417

I will let you know in this bug report when I think is a good point of time to update the sources.

Great, thank you for letting us know!

Comment 3

[Dan Minor [:dminor]]

Hi Michael, we might be seeing the deadlock you mentioned or something similar in Firefox, see Bug 1620871. Any news on when it might be safe for us to update? Thank you!

Comment 4

[Michael Tüxen]

Still working in the fix. An amount of code needed a cleanup and improvement of consistency to get the patch working. I'll let you know as soon as it is committed.