1613900 - Incorrect exception when SharedArrayBuffer cannot be serialized

Status: RESOLVED FIXED

(Core :: DOM: postMessage, defect)

Description

[Anne (:annevk)]

WPT html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/no-coop-coep.https.any.js (run as html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/no-coop-coep.https.any.html for instance) shows that we throw a TypeError rather than a DataCloneError.

html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/serialization-via-history.https.html also tests this and a number of other files in that directory do too.

Comment 1

[Anne (:annevk)]

This is also a problem for ArrayBuffer objects as per html/infrastructure/safe-passing-of-structured-data/transfer-errors.window.html.

Comment 2

[Tom Tung [:tt, :ttung]]

(In reply to Anne (:annevk) from comment #0)

WPT html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/no-coop-coep.https.any.js (run as html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/no-coop-coep.https.any.html for instance) shows that we throw a TypeError rather than a DataCloneError.

html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/serialization-via-history.https.html also tests this and a number of other files in that directory do too.

The problem is probably because, for instance, we throw a JS exception here before we throw a DOM exception.

The question is that if we want to keep the error message for COOP and COEP headers, we might need to expose a new method in Spidermonkey to get the error message from a JSException and then throw that with DATA_CLONE_ERR.

Comment 3

[Tom Tung [:tt, :ttung]]

Attachment: Bug 1613900 - P1 - Throw the data clone error if COOP and COEP headers are not set when there is an shared memory object;

Comment 4

[Tom Tung [:tt, :ttung]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=897f63912d386402e481e8323d270d337873132b

Comment 5

[Tom Tung [:tt, :ttung]]

Attachment: Bug 1613900 - P2 - Report original JS error message to StructuredCloneCallbacksError;

Depends on D62232

Comment 6

[Tom Tung [:tt, :ttung]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c507521cbf5c5709f0cb1674043237b65814346e

Comment 7

[Tom Tung [:tt, :ttung]]

Hmm, there seem to have too many cases where we fail to serialize/deserialize a buffer and JS side doesn't call the error callback. So, I will probably remove the assertion before throwing (for ensuring error callback must propagate the message to DOM side while throwing).

Here is the try with the newest patch and puls removing the assertion to ensure mErrorMessage is not empty right before throwing:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e21ce6f32ff4666e80923f6a9b57b351968a3e4c

Comment 8

[Tom Tung [:tt, :ttung]]

Attachment: Bug 1613900 - P3 - ServiceWorker should treat all failures after deserializing as deserialization failures;

Depends on D62260

Comment 9

[Tom Tung [:tt, :ttung]]

Attachment: Bug 1613900 - P4 - Propagate the exception by setting a pending exception to the JSContext;

Depends on D62881

Comment 10

[Tom Tung [:tt, :ttung]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4d2b10da1798e31c2d36a31cdc1858ac9b33627c

Comment 11

[Tom Tung [:tt, :ttung]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=18fc2d4544e11d1b8bf42e68b988ceb42bdf3de2

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6f2315156e4f
P1 - Throw the data clone error if COOP and COEP headers are not set when there is an shared memory object; r=baku,sfink
https://hg.mozilla.org/integration/autoland/rev/5cfb3def4827
P2 - Report original JS error message to StructuredCloneCallbacksError; r=baku,sfink
https://hg.mozilla.org/integration/autoland/rev/819fac5523c2
P3 - ServiceWorker should treat all failures after deserializing as deserialization failures; r=dom-workers-and-storage-reviewers,perry
https://hg.mozilla.org/integration/autoland/rev/ee476560631f
P4 - Propagate the exception by setting a pending exception to the JSContext; r=baku

Comment 13

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/6f2315156e4f
https://hg.mozilla.org/mozilla-central/rev/5cfb3def4827
https://hg.mozilla.org/mozilla-central/rev/819fac5523c2
https://hg.mozilla.org/mozilla-central/rev/ee476560631f