Closed Bug 1613902 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 21656 - Convert returned binary data from call() to string

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox75 fixed)

RESOLVED FIXED
mozilla75
Tracking Status
firefox75 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 21656 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/21656
Details from upstream follow.

Ziran Sun <zsun@igalia.com> wrote:

Convert returned binary data from call() to string

This changes is based on the same cause as
commit 6ea4b6f95f85e8a425e827ddddc5f2caa06755c3

subprocess.check_output() returns binary data as output. In python2,
binary is basically an alias of str so it can be directly used as a
normal string. However in python3 the binary data is different to a
string. Inserting binary data into a string in python3 generates
strings like '/some/path/with/b'binary'/data/inserted' which are not
correct file paths. We must decode() the returned data in order to use
it as a string.

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → INVALID
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/aadcecb663b4
[wpt PR 21656] - Convert returned binary data from call() to string, a=testonly
Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla75
You need to log in before you can comment on or make changes to this bug.