1614013 - One marker and one profiler label got moved to a different scope accidentally

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect, P2)

Description

[Markus Stange [:mstange]]

The second patch from bug 1578329 contained two mistakes: AUTO_PROFILER_* RAII objects were moved into a more limited scope than before. For AUTO_PROFILER_TEXT_MARKER_*, this means that the marker duration will be too short, and for AUTO_PROFILER_LABEL_*, this means that the label won't show up on the stack where it's needed.

https://hg.mozilla.org/integration/autoland/rev/4b97efacdf38#l3.27
https://hg.mozilla.org/integration/autoland/rev/4b97efacdf38#l10.18

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Thank you Markus. On it.

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1614013 - Fix RAII Profiler object scopes - r?gregtatum

In bug 1578329 I introduced two scoping mistakes:

• A marker was made to have a shorter duration.
• A label was scoped too short and so would most likely be missed during
  sampling.
  This patch reverts to the original wider scope.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ead246c1f024
Fix RAII Profiler object scopes - r=gregtatum

Comment 4

[Markus Stange [:mstange]]

Thank you for fixing this so quickly!

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/ead246c1f024