1614019 - AudioContext allows specifying a negative sampleRate

Status: RESOLVED FIXED

(Core :: Web Audio, defect, P3)

Description

[Boris Zbarsky [:bzbarsky]]

Maybe this is intentional, but I would have expected this:

new AudioContext({sampleRate: -1 })

to throw, since that's smaller than MinSampleRate. In Firefox it does not throw, because the bounds checks on sampleRate are skipped if it's <= 0 in AudioContext::Constructor. Is that on purpose? It might be worth a comment explaining why.

Comment 1

[nazarcf]

Attachment: Bug 1614019 - For an audioContext, a negative value of sampeRate now throws an exception r?padenot

Comment 2

[carnould]

Attachment: Bug 1614019 - Removed negative value from the valid range r?padenot

0 is not considered because this is the default value.
The condition in the if is changed because the minus operation could overflow.
The declaration of sampleRate has been moved to its next use because its first value was never used.

Comment 3

[carnould]

Attachment: Bug 1614019 - Added mochitest for negative sample rate. r?padenot

Depends on D81550

Comment 4

[carnould]

Attachment: Bug 1614019 - Added wpt for negative sample rate. r?padenot

Depends on D83925

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8b700a13395e
Removed negative value from the valid range r=padenot,webidl,smaug
https://hg.mozilla.org/integration/autoland/rev/18cf45575936
Added mochitest for negative sample rate. r=padenot
https://hg.mozilla.org/integration/autoland/rev/c5f74915fe26
Added wpt for negative sample rate. r=padenot

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/24825 for changes under testing/web-platform/tests

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/8b700a13395e
https://hg.mozilla.org/mozilla-central/rev/18cf45575936
https://hg.mozilla.org/mozilla-central/rev/c5f74915fe26

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot