1614036 - Fix error reporting in WebAudioDecodeJob::OnFailure

Status: RESOLVED FIXED

(Core :: Web Audio, defect, P3)

Description

[Boris Zbarsky [:bzbarsky]]

Right now this code does the following:

1. Grab a localized string for the error.
2. Report that to the console.
3. Pass a DOMException whose message is the name of that localized string (!) to the callback.
4. Reject the promise with a generic EncodingError DOMException.

It seems like we should be passing a sane (but NOT localized) string to both the DOMException and the Promise. One plausible thing to do is to pull these error messages out of the localized stuff completely, remove the manual console log, and just do the Promise rejection; if the page does not handle it I believe we will log it in the console.

Comment 1

[carnould]

Attachment: Bug 1614036 - Removed console logging and set unlocalized messages r?padenot

Changed error message to unlocalized in the callback and in the promise rejection in case an error occurs in audio decoding.

The result can be seen by looking at the console of this code https://jsfiddle.net/carnould/kzsc6xr0/27/

I don't know if it needs a proper test or how the localized message can be deleted in all languages.

Comment 2

[carnould]

Attachment: Bug 1614036 - Added mochitest. r?padenot

The test is skipped because we don't give the appropriate error to WebAudioDecodeJob::OnFailure()

Depends on D81337

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/613fb2320c9c
Removed console logging and set unlocalized messages r=padenot
https://hg.mozilla.org/integration/autoland/rev/ce92439ba700
Added mochitest. r=padenot

Comment 4

[Paul Adenot (:padenot)]

Attachment: Bug 1614036 - Remove more error handling code that is now useless, on a CLOSED TREE.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e0b4821cde64
Remove more error handling code that is now useless, on a CLOSED TREE.

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/613fb2320c9c
https://hg.mozilla.org/mozilla-central/rev/ce92439ba700
https://hg.mozilla.org/mozilla-central/rev/e0b4821cde64