1614082 - Minor flexbox cleanup

Status: RESOLVED FIXED

(Core :: Layout: Flexbox, task, P3)

Description

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Some cleanup patches while reading flexbox's code.

Comment 1

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1614082 Part 1 - Remove unused axis tracker arguments from FlexItem methods. r=dholbert

Comment 2

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1614082 Part 2 - Rename nsStyleDisplay argument on ShouldUseMozBoxCollapseBehavior() to match its declaration in the header. r=dholbert

Depends on D62131

Comment 3

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1614082 Part 3 - Fix static-analysis nits in nsFlexContainerFrame.cpp. r=dholbert

This patch is generated via
./mach static-analysis check -f layout/generic/nsFlexContainerFrame.cpp and
./mach clang-format.

Depends on D62132

Comment 4

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1614082 Part 4 - Add spec links to steps in the flex layout algorithm. r=dholbert

Depends on D62133

Comment 5

[Daniel Holbert [:dholbert]]

Thanks for doing these fixups!

Comment 6

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Thanks for the review!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e3593de6ea5d
Part 1 - Remove unused axis tracker arguments from FlexItem methods. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/7ccb28e5a2ef
Part 2 - Rename nsStyleDisplay argument on ShouldUseMozBoxCollapseBehavior() to match its declaration in the header. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/4aa7e1fca6f2
Part 3 - Fix static-analysis nits in nsFlexContainerFrame.cpp. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/cb56699431a0
Part 4 - Add spec links to steps in the flex layout algorithm. r=dholbert

Comment 8

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/e3593de6ea5d
https://hg.mozilla.org/mozilla-central/rev/7ccb28e5a2ef
https://hg.mozilla.org/mozilla-central/rev/4aa7e1fca6f2
https://hg.mozilla.org/mozilla-central/rev/cb56699431a0