Closed Bug 1614082 Opened 3 years ago Closed 3 years ago

Minor flexbox cleanup

Categories

(Core :: Layout: Flexbox, task, P3)

task

Tracking

()

RESOLVED FIXED
mozilla74
Tracking Status
firefox74 --- fixed

People

(Reporter: TYLin, Assigned: TYLin)

Details

Attachments

(4 files)

Some cleanup patches while reading flexbox's code.

This patch is generated via
./mach static-analysis check -f layout/generic/nsFlexContainerFrame.cpp and
./mach clang-format.

Depends on D62132

Thanks for doing these fixups!

Thanks for the review!

Pushed by aethanyc@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/e3593de6ea5d
Part 1 - Remove unused axis tracker arguments from FlexItem methods. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/7ccb28e5a2ef
Part 2 - Rename nsStyleDisplay argument on ShouldUseMozBoxCollapseBehavior() to match its declaration in the header. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/4aa7e1fca6f2
Part 3 - Fix static-analysis nits in nsFlexContainerFrame.cpp. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/cb56699431a0
Part 4 - Add spec links to steps in the flex layout algorithm. r=dholbert
You need to log in before you can comment on or make changes to this bug.