1614136 - ./mach package fails locally referencing devtools/client/toolbox.dtd

Status: RESOLVED FIXED

(Firefox Build System :: General, defect, P3)

Description

[Emilio Cobos Álvarez (:emilio)]

On clean central debug build, running ./mach package after ./mach build I get:

 0:34.93 Traceback (most recent call last):
 0:34.93   File "/usr/lib64/python2.7/runpy.py", line 174, in _run_module_as_main
 0:34.93     "__main__", fname, loader, pkg_name)
 0:34.93   File "/usr/lib64/python2.7/runpy.py", line 72, in _run_code
 0:34.93     exec code in run_globals
 0:34.93   File "/home/emilio/src/moz/gecko-4/python/mozbuild/mozbuild/action/zip.py", line 46, in <module>
 0:34.93     main(sys.argv[1:])
 0:34.93   File "/home/emilio/src/moz/gecko-4/python/mozbuild/mozbuild/action/zip.py", line 42, in main
 0:34.93     jarrer.copy(mozpath.join(args.C, args.zip))
 0:34.93   File "/home/emilio/src/moz/gecko-4/python/mozbuild/mozpack/copier.py", line 597, in copy
 0:34.93     file.copy(deflater, skip_if_older)
 0:34.93   File "/home/emilio/src/moz/gecko-4/python/mozbuild/mozpack/files.py", line 227, in copy
 0:34.93     shutil.copyfileobj(self.open(), dest)
 0:34.93   File "/home/emilio/src/moz/gecko-4/python/mozbuild/mozpack/files.py", line 256, in open
 0:34.93     return _open(self.path, mode=mode)
 0:34.93   File "/home/emilio/src/moz/gecko-4/python/mozbuild/mozpack/files.py", line 83, in _open
 0:34.93     return open(path, mode)
 0:34.93 IOError: [Errno 2] No such file or directory: u'../../dist/xpi-stage/locale-en-US/browser/chrome/en-US/locale/en-US/devtools/client/toolbox.dtd'

This used to work not long ago, and is what I used to pull built-firefoxes for testing from my build machine when working over ssh :)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

There's a file in a slightly different path: obj-debug/dist/xpi-stage/locale-en-US/browser/chrome/en-US/locale/en-US/devtools/client/toolbox.dtd

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Oh, same path I guess... Though file is empty.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

If I remove the empty file then packaging succeeds...

Comment 4

[Chris Manchester (limited bugmail, email directly)]

I wasn't able to reproduce this from a clean build. Were you editing something in particular when this happened?

Comment 5

[Emilio Cobos Álvarez (:emilio)]

No, not really. But I think I had built before bug 1608022 (which removed that file) landed, then rebased, then built again.

Comment 7

[Chris Manchester (limited bugmail, email directly)]

Ah, I had thought this happened starting from an entirely clean build. This seems to be the langpack machinery's version of bug 1614136.

Comment 8

[Chris Manchester (limited bugmail, email directly)]

I suppose we can add a similar workaround here to make the copier ignore broken links, but it also looks like clobbering the output dir before making a langpack might be reasonable...

Comment 9

[Chris Manchester (limited bugmail, email directly)]

Attachment: Bug 1614136 - Clobber langpack output before packaging to avoid failures due to stale symlinks.

Comment 10

[Chris Manchester (limited bugmail, email directly)]

These steps don't seem to be doing anything meaningfully incremental in the first place, so I posted a patch to just clobber the output dir each time.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b049b0bbe77d
Clobber langpack output before packaging to avoid failures due to stale symlinks. r=nalexander

Comment 12

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/b049b0bbe77d