Closed Bug 1614139 Opened 4 months ago Closed 4 months ago

nsPipe3.cpp: copy constructor should not be declared explicit

Categories

(Firefox Build System :: Source Code Analysis, task)

task
Not set
normal

Tracking

(firefox75 fixed)

RESOLVED FIXED
mozilla75
Tracking Status
firefox75 --- fixed

People

(Reporter: Sylvestre, Assigned: tuan.mate, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug, Whiteboard: [lang=C++])

Attachments

(1 file, 1 obsolete file)

Filling as a good first bug to learn workflows.

copy constructor should not be declared explicit
https://searchfox.org/mozilla-central/source/xpcom/io/nsPipe3.cpp#159
As the change is trivial, it is just to learn how to contribute to Firefox.

Found by http://clang.llvm.org/extra/clang-tidy/checks/google-explicit-constructor.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html

Hi. I would like to work on this.

Sure Please provide a patch

Assignee: nobody → tuan.mate
Status: NEW → ASSIGNED
Attachment #9126241 - Attachment is obsolete: true
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8e18b9d4caae
Copy constructor of nsPipeInputStream should not be declared explicit. r=froydnj
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla75
You need to log in before you can comment on or make changes to this bug.