1614139 - nsPipe3.cpp: copy constructor should not be declared explicit

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, task)

Description

[Sylvestre Ledru [:Sylvestre]]

Filling as a good first bug to learn workflows.

copy constructor should not be declared explicit
https://searchfox.org/mozilla-central/source/xpcom/io/nsPipe3.cpp#159
As the change is trivial, it is just to learn how to contribute to Firefox.

Found by http://clang.llvm.org/extra/clang-tidy/checks/google-explicit-constructor.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html

Comment 1

[siddharth_yadav]

Hi. I would like to work on this.

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Sure Please provide a patch

Comment 3

[Tuan]

Attachment: Bug 1614139 - Copy constructor of nsPipeInputStream should not be declared explicit. r=Sylvestre

Comment 4

[Tuan]

Attachment: Bug 1614139 - Copy constructor of nsPipeInputStream should not be declared explicit. r=froydnj

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8e18b9d4caae
Copy constructor of nsPipeInputStream should not be declared explicit. r=froydnj

Comment 6

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/8e18b9d4caae