Closed Bug 1614273 Opened 5 years ago Closed 5 years ago

Can not create MDN account when entered with GitHub account (submit button not works)

Categories

(developer.mozilla.org Graveyard :: Sign-in, defect)

Product:
developer.mozilla.org Graveyard
Component:
Sign-in
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: solovyov-alexander, Unassigned)

Details

Attachments

(3 files)

console_after_button_click.jpeg
32.81 KB, image/jpeg
Details
form_click_action_fragment.jpeg
71.09 KB, image/jpeg
Details
All information about my browser in xhtml file. ONE CORRECTION: russian language pack was enabled at test time.
31.56 KB, application/xhtml+xml
Details

User Agent: Mozilla/5.0 (X11; Linux i686; rv:60.0) Gecko/20100101 Firefox/60.0

Steps to reproduce:

At MDN site (https://developer.mozilla.org/en-US/docs/MDN/About) I clicked "Sign in" link to create new account.
Then I choose to use existing GitHub account and entered my GitHub account with username and password.
GitHub asked me to verify the device by entering code sent by email.
I received the email and entered this code.
Then I saw the page that said that MDN site connects to GitHub to get my account.
Looks like MDN site said that I am signed up with GitHub account and now need to create MDN account.
Now, when I go to signup page (https://developer.mozilla.org/ru/users/account/signup) I see the page with big header "Create your MDN account", and two pictures with captions. Left picture, "Authorize with GitHub", is marked with green mark. Right picture, "Create MDN account", is not marked. Also page contains my username and email from GitHub account (I can change them - and tried to change user name a couple of times) and a radio box "I agree...". I read license agreements, returned to "signup" page with browsers "Previous page" button, checked box "I agree..." and clicked "Create profile" button.

P.S. I use browser Firefox 60.9.0esr running on Rosa Fresh R11 Linux (Russian Mandriva-like distribution of Linux) with KDE Plasma 5 desktop.

Actual results:

When i click the "Create profile" button, just nothing happens.

Expected results:

I suppose to see next page, with message like "Welcome, now You are MDN member". Or an error message like "You must choose other username - somebody else already uses it", or some other message.

Hi! Thank you for taking the time to help MDN.

So, what you're trying to do should work but clearly we have a bug somewhere. You're saying that pressing the blue "Create profile" button does nothing. No errors? No loading? No nothing?
Do you think you can try again but this time open the Web Console and see if there are any interesting errors or warnings there that you might be able to take a screenshot of and upload to us here in this bug.

Browser's console after click on blue "Create profile" button.

Hello! Also when I look at the form action in the browser's Inspector, I see that maybe only two functions work on click of a button with an id==="create_mdn_account" - "Create profile" button:
event.preventDefault();
animateAvatar(signupForm)

and it seems like animateAvatar() not creates profile.
Am I right?

No, it seems like animateAvatar() have some error in it: "event" variable is not defined! Maybe "event.target" must be replaced with "form" there?..

(In reply to Aleksandr Solovyov from comment #4)

No, it seems like animateAvatar() have some error in it: "event" variable is not defined! Maybe "event.target" must be replaced with "form" there?..

Hey Aleksandr,

Thanks again for reporting. This problem, as well as a couple of others, will be resolved by https://github.com/mdn/kuma/pull/6371 which in all likelihood will be merged and released to production today.

(In reply to Aleksandr Solovyov from comment #4)

No, it seems like animateAvatar() have some error in it: "event" variable is not defined! Maybe "event.target" must be replaced with "form" there?..

Hey Aleksandr,

Quick update on this issue. We closed out https://github.com/mdn/kuma/pull/6371 and are refocussing the effort there on more concrete, focused individual issues. The first one I believe was related to the problem you are facing https://github.com/mdn/kuma/pull/6487

It has been merged and I believe pushed out to production. If you have a moment we would appreciate it if you could test it and let us know whether the problem has indeed been resolved, or whether you are still seeing the same problem.

Thank you.

Flags: needinfo?(solovyov-alexander)

Hello, Peter!
Thank You for quick answers. I tested it and now button works, with no error messages in console!..
But it led me back to the page on which I clicked "Sign in" link, with message of what has happened: am i signed in or not!
I received an e-mail from "no-reply@mozilla.org ", it says that I created a profile.
Now, when load any MDN page, I see "Sign in" button again in the upper right corner.

When I am at "https://developer.mozilla.org/en-US/docs/MDN/About", click it - and nothing happens, even no messages in browser's console!

When I am at "https://developer.mozilla.org/ru/docs/MDN/Getting_started" - I click "Sign in" and see an error in console:
"Загрузка <script> по адресу «https://lux.speedcurve.com/lux/?v=192&id=108906238&sid=158167126406391747&uid=158167054148707406&l=Mozilla%20-%20%D0%91%D1%8B%D1%81%D1%82%D1%80%D1%8B%D0%B9%20%D1%81%D1%82%D0%B0%D1%80%D1%82!%20-%20%D0%9F%D1%80%D0%BE%D0%B5%D0%BA%D1%82%20MDN%20%7C%20MDN&IX=c|560537,cx|1213,cy|71,ci|react-container&FID=6» не удалась."

When I am at "https://developer.mozilla.org/en-US/docs/Glossary" - I click "Sign in" and see almost similar error in console but for different URL:
Загрузка <script> по адресу «https://lux.speedcurve.com/lux/?v=192&id=108906238&sid=158167059638539115&uid=158167054148707406&l=MDN%20Web%20Docs%20Glossary%3A%20Definitions%20of%20Web-related%20terms%20%7C%20MDN&IX=s|5775,c|13300,cx|1214,cy|15,ci|react-container&FID=22» не удалась.

Russian words here means "Loading <script> at address .... failed".

So now I can not access my account at MDN.
Maybe I have to create new bug report?

Flags: needinfo?(solovyov-alexander)

Ops, I made an error in text: there was NO any message shown when I clicked "Sign in" - it just jumped to previous page.

Hey Aleksandr,

We are making progress :)

Russian words here means "Loading <script> at address .... failed".

This looks to be the Speedcurve LUX script. It failing should not cause the rest of the JavaScript to fail though.

Thank You for quick answers. I tested it and now button works, with no error messages in console!..
But it led me back to the page on which I clicked "Sign in" link, with message of what has happened

Sending you back to the page is correct, but there should have been a message to confirm that you have successfully created an account. I will create an issue for this.

The fact that you received the email does mean that your account was created though.

RE: Sign in link problems

I will have a look if I can replicate the problem of the sign-in link not working.

Information about your computer

Which browser and version are you using?
Can you perhaps share the extensions you are using? Particularly if you are using any privacy-related extensions such as Privacy Badger, uBlock etc.

Flags: needinfo?(solovyov-alexander)

Hello again! Here is all information about my browser.
ONE CORRECTION: russian language pack was enabled! I disabled it for a moment so You can easier read the report.
With russian language pack disabled - behavior of MDN pages is same, BUT there is no more messages in browser's console - it just does nothing when I click "Sign in" at right top corner of MDN pages.

One more thing: I tried to enter only by using GitHub account., as I registered myself at MDN using it.

I tried to sign out of GitHub and then again at MDN press that link "Sign in", and the only difference is that a dialog to sign in to GitHub is shown.
And when I enter my login and password - again, that MDN page showed and I am not signed in. After that, of course, at GitHub page I see that I am signed in. But at MDN "Sign in" does nothing at all.

Flags: needinfo?(solovyov-alexander)

Sorry, but after changing language back to russian I can not see any messages in browser's console. (But still can't sign in to MDN).
Maybe updating Firefox to 68.0 will fix the problem?

(In reply to Aleksandr Solovyov from comment #11)

Sorry, but after changing language back to russian I can not see any messages in browser's console. (But still can't sign in to MDN).
Maybe updating Firefox to 68.0 will fix the problem?

Thank you so much for all of this information. It might be that upgrading will solve the problem, but let me test the flow with the same version of Firefox you are using and see if I can find anything that suggests that it is related to the version of Firefox.

Hey Aleksandr,

I have tested with Firefox 60 and I can replicate your problem. Here are the steps I followed.

  1. Go to https://developer.mozilla.org
  2. Click the Sign in link top right
  3. I am sent to Github to authenticate.
  4. Once the authentication on the Github website is complete, I am directed to the MDN signup page to create my account
  5. I keep the default username and email address and check the privacy/terms checkbox
  6. Click on Create profile

I am redirected to https://developer.mozilla.org but, instead of my avatar and the user menu being displayed at the top right, I see a Sign in link. I do however receive the email that my signup was successful. Clicking on the Sign-in link seems to essentially just reload the page and I am still not signed in.

Because I know what the URL would be for my user profile, I decided to test something. I entered the following into the URL bar:
https://developer.mozilla.org/es-US/profiles/mdnwebdocs-tester/edit

And there it is, I am logged in and can edit my profile. Looking at the top right now, I am presented with my user avatar and hovering over it shows the user options menu.

This portion of the site runs on the underlying wiki.developer.mozilla.org codebase so, this suggest that there is a bug with the whoami widget that runs on developer.mozilla.org

Looking at the JSON returned from the call to whoami the username is null, and is_authenticated is false. I also noticed that the avatar_url is null. There are no errors in the developer console.

I can however also confirm that this does work correctly in Firefox 68

:peterbe should we move this into our Github issues list and investigate further?

Flags: needinfo?(peterbe)

Hello, thanks for Your work!
I think it would be good to do one of folowing things:

  • Test user agent when site loads and, if it is Firefox older than 68.0 - show a warning message at the top of the page "Your browser is not fully supported, please update";
    --or--
  • At least show this message when user wants to create an account (clicks "Sign in" button the first time);
    --or--
  • Fix this bug with "Sign in" link.

Don't know why, but I can not drop "needinfo" flag at Bugzilla. The radio box not shows up...

(In reply to Aleksandr Solovyov from comment #15)

Don't know why, but I can not drop "needinfo" flag at Bugzilla. The radio box not shows up...

No worries, the needinfo is for Peter.

(In reply to Aleksandr Solovyov from comment #14)

Hello, thanks for Your work!
I think it would be good to do one of folowing things:

  • Test user agent when site loads and, if it is Firefox older than 68.0 - show a warning message at the top of the page "Your browser is not fully supported, please update";

I agree. I noticed while testing this that, that is what Github does. Of course, if we can resolve the problem with the component, that is even better :)

I have a theory!
In the olden days, when fetch came out, you had to explicity set {credentials: 'same-origin'} to tell the browser to do the XHR request WITH the current domain cookies.
We could just add that here: https://github.com/mdn/kuma/blob/7bc235c91316681ecba2df53d7e631a77493b7a7/kuma/javascript/src/user-provider.jsx#L48

:espressive, if you can reproduce the problem, can you simply change that line to:

fetch('/api/v1/whoami', {
    // Needed to support really old browsers who's native fetch 
    // implementation didn't include credentials by default. 
    // Let's remove this thing by 2021. 
    credentials: 'same-origin'
})
Flags: needinfo?(peterbe)

Hey Aleksandr, I wanted to check in on this issue. Have you been able to upgrade to a newer version of Firefox? If so, is this issue resolved for you now? Thank you.

Flags: needinfo?(solovyov-alexander)

Hello. I updated my browser to Firefox 68.4.1esr (32-bit) and now when any "MDN web docs" page loads, it shows my avatar and "Edit in wiki" button - I am logged in! It works now!
So I confirm that issue is resolved for me.
I think that the primary bug was solved long ago, so maybe we should mark this bug as fixed?
Thanks to you all.

Flags: needinfo?(solovyov-alexander)

(In reply to Aleksandr Solovyov from comment #20)

Hello. I updated my browser to Firefox 68.4.1esr (32-bit) and now when any "MDN web docs" page loads, it shows my avatar and "Edit in wiki" button - I am logged in! It works now!
So I confirm that issue is resolved for me.
I think that the primary bug was solved long ago, so maybe we should mark this bug as fixed?
Thanks to you all.

Thank you so much for letting us know. I am glad that the problem is resolved and that MDN works as expected for you. o/\o

Status: UNCONFIRMED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Product: developer.mozilla.org → developer.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: