Closed
Bug 1614432
Opened 5 years ago
Closed 5 years ago
nsGridContainerFrame.cpp: Remove a nested redundant #if
Categories
(Core :: Layout: Grid, task, P3)
Core
Layout: Grid
Tracking
()
RESOLVED
FIXED
mozilla75
| Tracking | Status | |
|---|---|---|
| firefox75 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: fronkc1, Mentored)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug, Whiteboard: [lang=C++])
Attachments
(1 file)
Filling as a good first bug to learn workflows.
DEBUG is checked twice and we are in the same block
https://searchfox.org/mozilla-central/source/layout/generic/nsGridContainerFrame.cpp#8432
As the change is trivial, it is just to learn how to contribute to Firefox.
Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-redundant-preprocessor.html
Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html
Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.
|
Assignee | |
Comment 1•5 years ago
|
||
|
||
Updated•5 years ago
|
Assignee: nobody → fronkc1
Status: NEW → ASSIGNED
|
||
Comment 2•5 years ago
|
||
Looks like the redundant if was added in bug 1415683. Adding dependency.
Component: Lint and Formatting → Layout: Grid
Depends on: 1415683
Product: Firefox Build System → Core
Pushed by dholbert@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ed8cb267cf2a
Remove redundant nested #IF r=dholbert
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox75:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla75
You need to log in
before you can comment on or make changes to this bug.
Description
•