161450 - New search knob causes warnings

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect)

Description

[Jouni Heikniemi]

Every time I search for something, the following errors appear. It seems to be
the new search knob, therefore assigning to Gerv.

Sorry, I don't have the time to even look at this myself right now :-(

--
Use of uninitialized value in numeric eq (==) at
        /var/www/bugzilla/tip/buglist.cgi line 296 (#1)
    (W uninitialized) An undefined value was used as if it were already
    defined.  It was interpreted as a "" or a 0, but maybe it was a mistake.
    To suppress this warning assign a defined value to your variables.

    To help you figure out what was undefined, perl tells you what operation
    you used the undefined value in.  Note, however, that perl optimizes your
    program and the operation displayed in the warning may not necessarily
    appear literally in your program.  For example, "that $foo" is
    usually optimized into "that " . $foo, and the warning will refer to
    the concatenation (.) operator, even though there is no . in your
    program.

[Wed Aug  7 12:14:06 2002] buglist.cgi: Use of uninitialized value in numeric eq
(==) at /var/www/bugzilla/tip/buglist.cgi line 296.
[Wed Aug  7 12:14:06 2002] buglist.cgi: Use of uninitialized value in numeric eq
(==) at /var/www/bugzilla/tip/buglist.cgi line 296.

Comment 1

[Gervase Markham [:gerv]]

Attachment: Patch v.1

Good catch. This should do the trick.

Gerv

Comment 2

[Bradley Baetz (:bbaetz)]

Comment on attachment 94500 [details] [diff] [review]
Patch v.1

r=bbaetz x2

strictly speaking, you cuold remove the test against |$::FORM{'remember'} == 1|
now, but you don't need to

Comment 3

[Gervase Markham [:gerv]]

Fixed.

Checking in buglist.cgi;
/cvsroot/mozilla/webtools/bugzilla/buglist.cgi,v  <--  buglist.cgi
new revision: 1.187; previous revision: 1.186
done

Gerv