1614591 - Warning: Failed prop type: Invalid prop `isClosed` of type `boolean` supplied to `FrameListContent`, expected `function`

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect, P3)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

STR:

1. Open DevTools & select the Network panel & open the Browser Console
2. Load http://janodvarko.cz/test/websockets/
3. Click the Connect button
4. Click the Send button a few times
5. Select the WS 101 request
6. Select the Messages side panel
7. Check out the Browser Console it shows the following error:

Warning: Failed prop type: Invalid prop `isClosed` of type `boolean` supplied to `FrameListContent`, expected `function`.
    in FrameListContent
    in Unknown (created by Connect(Component))
    in Connect(Component) (created by WebSocketsPanel)
    in div (created by SplitBox)
    in div (created by SplitBox)
    in SplitBox (created by WebSocketsPanel)
    in div (created by WebSocketsPanel)
    in WebSocketsPanel
    in VisibilityHandler
    in Unknown (created by Connect(Component))
    in Connect(Component) (created by TabboxPanel)
    in div (created by Panel)
    in Panel (created by TabboxPanel)
    in div (created by Tabs)
    in div (created by Tabs)
    in div (created by Tabs)
    in Tabs (created by Sidebar)
    in Sidebar (created by Tabbar)
    in div (created by Tabbar)
    in Tabbar (created by TabboxPanel)
    in TabboxPanel (created by NetworkDetailsPanel)
    in div (created by NetworkDetailsPanel)
    in NetworkDetailsPanel
    in VisibilityHandler
    in Unknown (created by Connect(Component))
    in Connect(Component) (created by MonitorPanel)
    in div (created by SplitBox)
    in div (created by SplitBox)
    in SplitBox (created by MonitorPanel)
    in div (created by MonitorPanel)
    in MonitorPanel
    in VisibilityHandler
    in Unknown (created by Connect(Component))
    in Connect(Component) (created by App)
    in div (created by DropHarHandler)
    in DropHarHandler (created by App)
    in div (created by App)
    in App
    in VisibilityHandler
    in Unknown (created by Connect(Component))
    in Connect(Component)
    in Provider

Comment 1

[Pranav pandey]

when I am clicking on connect button I am getting 400 bad request

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Yeah, it happens sometimes when connecting to: ws://echo.websocket.org/
You might try another WS server

Or you might try this page:
http://signalr-samples.azurewebsites.net/hubs.html

Any page that generates some WS traffic can be used to repro the issue.

Honza

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Also note that you need ac_add_options --enable-debug-js-modules in your .mozconfig

Honza

Comment 4

[Pranav pandey]

Attachment: Screenshot 2020-02-12 at 5.46.02 PM.png

i still cannot reproduce it ,

Comment 5

[Pranav pandey]

I have reproduced it thanks for help

Comment 6

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Great! (let me know if you want to me assigned)

Honza

Comment 7

[Pranav pandey]

Attachment: Bug 1614591 - changed prop type of isClosed to bool.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2a7f4d65cd26
changed prop type of isClosed to bool. r=Honza

Comment 9

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/2a7f4d65cd26