Remove optimization tracking
Categories
(Core :: JavaScript Engine: JIT, task, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox75 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(9 files)
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review |
Optimization tracking was added a few years ago for JitCoach but it isn't really used and the code would have to be rewritten/redesigned for upcoming WarpBuilder work, so we decided to remove it now.
|
Assignee | |
Comment 1•4 years ago
|
||
It was used before the Ion ICs were converted to CacheIR, but it's dead code
now.
|
|
Assignee | |
Comment 2•4 years ago
|
||
Depends on D62425
|
|
Assignee | |
Comment 3•4 years ago
|
||
This also removes the Gecko profiler code where this was used.
Depends on D62426
|
|
Assignee | |
Comment 4•4 years ago
|
||
Depends on D62427
|
|
Assignee | |
Comment 5•4 years ago
|
||
Depends on D62428
|
|
Assignee | |
Comment 6•4 years ago
|
||
Depends on D62429
|
|
Assignee | |
Comment 7•4 years ago
|
||
Depends on D62430
|
|
Assignee | |
Comment 8•4 years ago
|
||
These patches remove most of it. After this lands we can wait for Searchfox to update and delete what's left.
|
||
Updated•4 years ago
|
|
||
Updated•4 years ago
|
Pushed by jdemooij@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/66b5abdb3ab1 part 1 - Remove IonCacheEntry. r=djvj https://hg.mozilla.org/integration/autoland/rev/ceea83206518 part 2 - Remove trackedOpts shell function. r=djvj https://hg.mozilla.org/integration/autoland/rev/001f6e5c408f part 3 - Remove optimization tracking from profiler backend, remove forEach API methods. r=djvj https://hg.mozilla.org/integration/autoland/rev/d330c85736d3 part 4 - Remove now unused youngestFrameLocationAtAddr. r=djvj https://hg.mozilla.org/integration/autoland/rev/18764bd9f497 part 5 - Remove most optimization tracking storage code. r=djvj https://hg.mozilla.org/integration/autoland/rev/6636f1a7b6c5 part 6 - Remove optimization tracking code from IonBuilder. r=djvj https://hg.mozilla.org/integration/autoland/rev/5ab5e1104a78 part 7 - Remove some now dead optimization tracking code. r=djvj
|
||
Comment 10•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/66b5abdb3ab1
https://hg.mozilla.org/mozilla-central/rev/ceea83206518
https://hg.mozilla.org/mozilla-central/rev/001f6e5c408f
https://hg.mozilla.org/mozilla-central/rev/d330c85736d3
https://hg.mozilla.org/mozilla-central/rev/18764bd9f497
https://hg.mozilla.org/mozilla-central/rev/6636f1a7b6c5
https://hg.mozilla.org/mozilla-central/rev/5ab5e1104a78
|
|
Assignee | |
Comment 11•4 years ago
|
||
|
|
Assignee | |
Comment 12•4 years ago
|
||
Depends on D62877
|
|
Assignee | |
Updated•4 years ago
|
|
||
Comment 13•4 years ago
|
||
Pushed by jdemooij@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3e3d749344df part 8 - Remove optimization tracking files. r=djvj https://hg.mozilla.org/integration/autoland/rev/62782fffe30c part 9 - Remove optimization tracking spew and flag. r=djvj
|
||
Comment 14•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/3e3d749344df
https://hg.mozilla.org/mozilla-central/rev/62782fffe30c
Description
•