1614623 - Simplify intersection observer property management code.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P2)

Description

[Emilio Cobos Álvarez (:emilio)]

This is causing problems with lazyload for relatively complex reasons. This is a simplification that doesn't fix the root of the problem, but is worth doing anyway.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1614623 - Simplify intersection observer property handling. r=smaug

Removes some duplicated code, and removes the property when the observer hash
table is empty (there's no reason to keep it around).

The keeping the property around is causing issues because we want to change
intersection observers on adopt.

Right now when that happens, we create a property on the new document, but then
override it with the transferred one if present.

We should instead merge the properties rather than transferring them to the new
document, or something. But not keeping the empty property mitigates the
problem.

We should still fix that though, I'll file another bug for it.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0da37b6e5823
Simplify intersection observer property handling. r=smaug

Comment 3

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/0da37b6e5823