Closed
Bug 1614629
Opened 5 years ago
Closed 5 years ago
Fix freeSpace check in CacheFileIOManager::OverLimitEvictionInternal
Categories
(Core :: Networking: Cache, defect, P1)
Core
Networking: Cache
Tracking
()
RESOLVED
FIXED
mozilla75
| Tracking | Status | |
|---|---|---|
| firefox75 | --- | fixed |
People
(Reporter: michal, Assigned: michal)
Details
(Whiteboard: [necko-triaged])
Attachments
(1 file)
Check at https://searchfox.org/mozilla-central/rev/a1592902acabf9bded973067133baaac1457f3d3/netwerk/cache2/CacheFileIOManager.cpp#2804 is wrong. The first part of the condition should check whether GetDiskSpaceAvailable() was successful, so there should be -1.
|
Assignee | |
Comment 1•5 years ago
|
||
Patch fixes wrong comparison. I also noticed that in bug 979900 I fixed just one freeSpace assignment after GetDiskSpaceAvailable() failure, see https://bugzilla.mozilla.org/show_bug.cgi?id=979900#c14. This patch fixes also other occurrences.
Pushed by mnovotny@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9574ef31b96b
Fix freeSpace check in CacheFileIOManager::OverLimitEvictionInternal r=mayhemer
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox75:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla75
You need to log in
before you can comment on or make changes to this bug.
Description
•