Closed
Bug 1614654
Opened 5 years ago
Closed 5 years ago
Simplify property handling during adoption.
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla75
Tracking | Status | |
---|---|---|
firefox75 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
Details
Attachments
(1 file)
Now that GetUserData and such are gone, we can simplify this, which will solve the issues bug 1542784 is hitting.
Assignee | ||
Comment 1•5 years ago
|
||
We don't need to transfer all properties after adopt. Collecting all the nodes
with properties during adopt was needed because there used to be clone and adopt
user-data callbacks, see https://bugzilla.mozilla.org/show_bug.cgi?id=347524.
This ensures that NodeInfoChanged and similar callbacks can tweak node
properties, which is needed for bug 1542784.
Also simplify surrounding code. As far as I can tell we should always have
different documents if we get a NodeInfoManager object.
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c5dd189b9172
Simplify property handling during adoption. r=smaug
Comment 3•5 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox75:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla75
You need to log in
before you can comment on or make changes to this bug.
Description
•