History search should ignore combining diacritics
Categories
(Toolkit :: Places, enhancement)
Tracking
()
People
(Reporter: alexhenrie24, Assigned: alexhenrie24)
Details
Attachments
(1 file)
Now that Bug 1611568 is fixed, diacritic-insensitive searches for text on a page ignore combining diacritic characters. The same should be true when searching the browser history (e.g. via the address bar) for a page that has a combining diacritic in its title or URL.
|
Assignee | |
Comment 1•4 years ago
|
||
IsCombiningDiacritic(-1) returns false, so there is no need to specially
handle -1 in GetLowerUTF8Codepoint_inline.
It is no longer necessary for GetNaked to check whether a character is a
combining character because all callers now skip combining diacritics
and GetNaked already makes sure that decomposition removes a diacritic
and not something else.
|
||
Updated•4 years ago
|
Pushed by apavel@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/19462e426dc3 Ignore combining diacritic characters in history search. r=jfkthame,mak
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
|
||
Comment 4•4 years ago
|
||
Updating qe tracking flags to reflect QA triage decision taken with :mdeboer in QA-Search weekly sync meeting.
Alex, could you list some steps to help reproducing/verifying this issue?
|
|
Assignee | |
Comment 5•4 years ago
|
||
You can visit a web page whose title contains an accented letter, such as https://ca.wikipedia.org/, and then type that title into the URL bar without accent marks ("Viquipedia" in this case). If the page appears in the search results, this feature is working correctly.
|
|
||
Comment 6•4 years ago
|
||
Thanks Alex for the info. Trying to reproduce this issue on 74, which should've been affected according to the report, didn't bear any fruit on my side. However, I'm marking this as verified since the problem is not reproducible on 75/76 as described in comment 5.
Tested on:
Ubuntu 18.04, macOS 10.13, Windows 10.
with:
76.0a1 Build ID 20200331093527
75.0b10 Build ID 20200326191140
Alex, if you find time to double check this verification, would be greatly apreciated.
|
|
Assignee | |
Comment 7•4 years ago
|
||
Sorry, I just realized that I gave you bad instructions: The page I suggested before has a precomposed character in its title. Here is a page that has a combining diacritic in its title: https://gn.wikipedia.org/wiki/G%CC%83uaiguingue
If after visiting that page you can search the address bar for "guaiguingue" and "G̃uaiguingue" appears, the bug is fixed.
Description
•