1614870 - Memory leak in on sid->peerID in ssl_DecodeResumptionToken

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P1)

Description

[Kevin Jacobs [:kjacobs]]

Bug 1607257 reports memory leaks when using external token caching. In SSLExp_SetResumptionToken, ssl3_NewSessionID allocates sid->peerID then ssl_DecodeResumptionToken does it again (via PORT_Strdup) without freeing.

Confirmed via https://treeherder.mozilla.org/#/jobs?repo=try&revision=adecc16291e291121ca2456cc5962928044177dc and https://treeherder.mozilla.org/#/jobs?repo=try&revision=9dadb29155c738a9bbba9bc9dc12aec641a355fc

It looks like gtests miss this case by not setting a peerID on the socket.

Comment 1

[Kevin Jacobs [:kjacobs]]

Attachment: Bug 1614870 - Free sid->peerID before reallocating in ssl_DecodeResumptionToken.

This patch adds a missing PORT_Free() when reallocating sid->PeerID, and adds a test for a non-empty PeerID.

Comment 2

[Kevin Jacobs [:kjacobs]]

https://hg.mozilla.org/projects/nss/rev/1eb4e00b016ec1c3fccc1d56081a4a4dc2eb494c

Comment 3

[Kershaw Chang [:kershaw]]

Hi Kevin,

Do you know when will this change be uplifted to mc?
If possible, I'd like to enable SSLTokensCache in next release cycle.

Thanks.

Comment 4

[Kevin Jacobs [:kjacobs]]

It was uplifted yesterday, though Searchfox hasn't updated yet: https://hg.mozilla.org/mozilla-central/rev/b356f4fe601fe1ceeaf4081b409944569ecaaa34