1614890 - Implement conic-gradient for WebRender graphics backend

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, task)

Description

[Tim Nguyen :ntim]

Splitting this out of bug 1175958, so it can land separately.

Comment 1

[Tim Nguyen :ntim]

Attachment: Bug 1614890 - Implement conic-gradient for WebRender graphics backend.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/53650b8686a6
Implement conic-gradient for WebRender graphics backend. r=gw,nical

Comment 3

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7a4bbabfcc67
Backed out changeset 53650b8686a6 for causing webrender failures.

Comment 4

[Alexandru Michis [:malexandru]]

Backed out changeset 53650b8686a6 for causing webrender failures.

Backout link: https://hg.mozilla.org/integration/autoland/rev/7a4bbabfcc67993222cdf79ea8dd084adbd25352

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&tochange=7a4bbabfcc67993222cdf79ea8dd084adbd25352&fromchange=53650b8686a6cf9ff55b4f83e33042d97efd7a9d&searchStr=webrender

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=288483481&repo=autoland&lineNumber=910

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8f55490fb539
Implement conic-gradient for WebRender graphics backend. r=gw,nical

Comment 6

[Alexandru Michis [:malexandru]]

Backed out changeset 8f55490fb539 for causing awsy failures.

Backout link: https://hg.mozilla.org/integration/autoland/rev/63acd82c9360389a6dbd3bdf223e48bf32ca25c1

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&searchStr=are%2Cwe%2Cslim%2Cyet&fromchange=4d9e588f63570d35f8ff0de6b93fa8b575c2d003&tochange=c078d08afa05139cdd28659604214a3bf79adde9&selectedJob=288530424

Failure logs:

• https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=288536190&repo=autoland&lineNumber=1391
• https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=288536197&repo=autoland&lineNumber=1401

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/62a1a471e01c
Implement conic-gradient for WebRender graphics backend. r=gw,nical,emilio

Comment 8

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/62a1a471e01c

Comment 9

[Alexandru Ionescu (needinfo me) [:alexandrui]]

(In reply to Pulsebot from comment #2)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/53650b8686a6
Implement conic-gradient for WebRender graphics backend. r=gw,nical

== Change summary for alert #24915 (as of Wed, 12 Feb 2020 16:50:47 GMT) ==

Improvements:

12% Heap Unclassified windows10-64-qr opt 57,278,369.43 -> 50,659,938.34

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=24915

(In reply to Pulsebot from comment #3)

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7a4bbabfcc67
Backed out changeset 53650b8686a6 for causing webrender failures.

== Change summary for alert #24936 (as of Fri, 14 Feb 2020 06:55:17 GMT) ==

Regressions:

16% Heap Unclassified windows10-64-qr opt 49,313,397.37 -> 57,081,029.64
7% Heap Unclassified windows10-64-shippable opt 48,463,792.21 -> 51,767,845.60
6% Heap Unclassified windows10-64-shippable opt tp6 66,761,525.52 -> 70,853,934.95

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=24936

Comment 10

[Tim Nguyen :ntim]

Comment 9 says that landing it was a perf improvement, but back out was a perf regression, so in the end, this basically means no change happened.

Comment 11

[Florin Strugariu [:Bebe]]

:ntim you are right the regression was backed out sorry for the misleading tag.

Added the perf keywords so we are able to track the performance alerts