1614912 - Warning: Failed prop type: The prop `networkActionBarOpen` is marked as required in `Toolbar`

Status: VERIFIED FIXED

(DevTools :: Netmonitor, defect, P3)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

STR:

1. Open the Browser Console
2. Open the DevTools Toolbox
3. Select the Network panel
4. Check the Browser Console for the following warning:

Warning: Failed prop type: The prop `networkActionBarOpen` is marked as required in `Toolbar`, but its value is `undefined`.
    in Toolbar
    in Unknown (created by Connect(Component))
    in Connect(Component) (created by MonitorPanel)
    in div (created by MonitorPanel)
    in MonitorPanel
    in VisibilityHandler
    in Unknown (created by Connect(Component))
    in Connect(Component) (created by App)
    in div (created by DropHarHandler)
    in DropHarHandler (created by App)
    in div (created by App)
    in App
    in VisibilityHandler
    in Unknown (created by Connect(Component))
    in Connect(Component)
    in Provider

Also note that you need ac_add_options --enable-debug-js-modules in your .mozconfig to see the warning.

Honza

Comment 1

[Duncan Dean]

I'll have a go at this one. :)

Comment 2

[Duncan Dean]

Hmm, I cannot reproduce this warning. I did configure and build with ac_add_options --enable-debug-js-modules option too. 🤔
I might be missing something.

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

I can still see it. Did you make full rebuild after adding ac_add_options --enable-debug-js-modules into your .mozconfig?

Honza

Comment 4

[Duncan Dean]

Hmm. I recall doing a full rebuild but I will check later today at home (that computer has my personal dev environment).

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Make sure to remove the obj dir (with built files) and run mach build again

Honza

Comment 6

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Any luck with reproducing this?

I am seeing it all the time (Firefox Nightly, Win10)

Honza

Comment 7

[Duncan Dean]

Hmm. I still cannot reproduce on MacOS. 🤔

I have followed your instructions above but no luck.

Comment 8

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Hubert, can you reproduce this bug?

Honza

Comment 9

[Hubert Boma Manilla (:bomsy)]

Yes I can reproduce (Firefox Nightly Mac OS)

Comment 10

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Duncan, are you looking into the Browser Console ?
https://developer.mozilla.org/en-US/docs/Tools/Browser_Console

Honza

Comment 11

[Duncan Dean]

Hi Honza,

Ah. Was looking at the web console 🤦‍♂️
Sorry about that.

I can reproduce now.

Comment 12

[Kriti Singh]

Attachment: Bug 1614912: Prop not required in Toolbar

Comment 13

[Kriti Singh]

Attachment: Bug 1614912: Updated patch

Depends on D64594

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c9b772a1bdef
Prop not required in Toolbar r=Honza

Comment 15

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/c9b772a1bdef

Comment 16

[abodenlosz]

I have verified the issue with Firefox 75.0b1 and it is no longer reproducible.

Comment 17

[abodenlosz]

The verification took place on Windows 10 x64 Ubuntu 18.04 and macOS 10.15.

Comment 18

[Cristian Fogel [:cfogel]]

Awesome!
Updating status for the bug as well.