1614914 - TypeError: "can't access property "type", astExpression is undefined"

Status: RESOLVED FIXED

(DevTools :: Console, defect, P3)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: image.png

STR:

1. Open DevTools and select the Console panel
2. Make sure you have Eager Eval on
3. Open the Browser Console
4. Type debugger. (note the dot at the end)
5. Check out the Browser Console for the following errors (see also the attached screenshot

TypeError: "can't access property "type", astExpression is undefined"
    JSPropertyProvider resource://devtools/shared/webconsole/js-property-provider.js:137
    makeInfallible resource://devtools/shared/ThreadSafeDevToolsUtils.js:111
    autocomplete resource://devtools/server/actors/webconsole.js:1419
    handler resource://devtools/shared/protocol/Actor.js:154
    onPacket resource://devtools/server/debugger-server-connection.js:380
    receiveMessage resource://devtools/shared/transport/child-transport.js:66
    _addListener resource://devtools/shared/transport/child-transport.js:40
    ready resource://devtools/shared/transport/child-transport.js:57
    _onConnection resource://devtools/server/debugger-server.js:463
    connectToParent resource://devtools/server/debugger-server.js:337
    onConnect resource://devtools/server/startup/frame.js:62
    makeInfallible resource://devtools/shared/ThreadSafeDevToolsUtils.js:111
    MessageListener.receiveMessage* resource://devtools/server/startup/frame.js:95
    <anonymous> resource://devtools/server/startup/frame.js:177
ThreadSafeDevToolsUtils.js:90:13
Error while calling actor 'console's method 'autocomplete' can't access property "matches", result is undefined Actor.js:91:13
autocomplete@resource://devtools/server/actors/webconsole.js:1443:7
handler@resource://devtools/shared/protocol/Actor.js:154:37
onPacket@resource://devtools/server/debugger-server-connection.js:380:58
receiveMessage@resource://devtools/shared/transport/child-transport.js:66:16
MessageListener.receiveMessage*_addListener@resource://devtools/shared/transport/child-transport.js:40:14
ready@resource://devtools/shared/transport/child-transport.js:57:10
_onConnection@resource://devtools/server/debugger-server.js:463:15
connectToParent@resource://devtools/server/debugger-server.js:337:17
onConnect<@resource://devtools/server/startup/frame.js:62:35
exports.makeInfallible/<@resource://devtools/shared/ThreadSafeDevToolsUtils.js:111:22
MessageListener.receiveMessage*@resource://devtools/server/startup/frame.js:95:23
@resource://devtools/server/startup/frame.js:177:5
Actor.js:96:15
failed autocomplete Error: "Protocol error (unknownError): can't access property "matches", result is undefined"
    onPacket resource://devtools/shared/protocol/Front.js:276
    DevTools RDP*request resource://devtools/shared/protocol/Front.js:214
    name resource://devtools/shared/protocol/Front/FrontClassWithSpec.js:49
    autocompleteDataFetch resource://devtools/client/webconsole/actions/autocomplete.js:145
    Redux 3
    autocompleteUpdate resource://devtools/client/webconsole/actions/autocomplete.js:79
    Redux 2
    autocompleteUpdate resource://devtools/client/webconsole/components/Input/JSTerm.js:1324
    timer resource://devtools/shared/debounce.js:38
    notify resource://gre/modules/Timer.jsm:62
autocomplete.js:167:17

Honza

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

I can reproduce without eager evaluation. It's rather an issue in the autocomplete code.

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1614914 - Fix TypeError in JsPropertyProvider for debugger keyword. r=Honza.

A check is added, as well as a test to ensure everything
is okay.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/20fbd614fd7c
Fix TypeError in JsPropertyProvider for debugger keyword. r=Honza.

Comment 4

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/20fbd614fd7c