Readability backplate makes most of eBay white in High Contrast mode when the background should be black
Categories
(Core :: Layout, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox75 | --- | verified |
People
(Reporter: rosewoodmahogany, Assigned: emilio)
References
()
Details
(Keywords: access)
Attachments
(3 files, 1 obsolete file)
SHOULD BE BLACK.png
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:73.0) Gecko/20100101 Firefox/73.0
Steps to reproduce:
My whole screen is black with white fonts, & in firefox (for years) all sorts of images and text wouldn't show up.
But a recent update made all those images show up, but it also allowed objects ("html tables" basically) which could be white and take up your entire screen.
eg if you go to ebay and click on an item, the entire screen has a white background. To people with light sensitive eyes that's not usable.
Actual results:
"My eyes on fire!!!"
Expected results:
The big HTML "background objects" need to stay black.
|
||
Updated•4 years ago
|
|
Assignee | |
Comment 1•4 years ago
|
||
Thanks for reporting this. For what is worth, you can toggle browser.display.permit_backplate to false in about:config to restore the previous behavior.
|
|
Assignee | |
Comment 2•4 years ago
|
||
It seems ebay is using a background image for this:
html body {
background: url(https://ir.ebaystatic.com/pictures/aw/pics/cmp/ds3/imgbg.jpg) repeat 0 0 #f8f8f8;
}
So we have no way to tell whether the image is light or not unfortunately :/.
|
|
Assignee | |
Comment 3•4 years ago
|
||
So this is pretty tricky to fix unfortunately... Maybe we should add a setting to always ignore background-images, even when backplating?
|
|
Assignee | |
Comment 4•4 years ago
|
||
Confirming as this is an issue as the reporter notes. But this is not easy to fix other than adding some user-visible switch to prevent background-image from applying in HCM even when backplating.
|
||
Comment 5•4 years ago
|
||
ugh ebay why.
(In reply to Emilio Cobos Álvarez (:emilio) from comment #4)
Confirming as this is an issue as the reporter notes. But this is not easy to fix other than adding some user-visible switch to prevent background-image from applying in HCM even when backplating.
Yeah, I feel like we might want a way to disable background images on a per site basis? I think, with this and similar exceptions, the overall user experience of HCM is improved with backplate + background images.
|
|
||
Comment 6•4 years ago
|
||
FWIW Edge seems to do the same as us
|
|
||
Comment 7•4 years ago
|
||
|
||
Comment 8•4 years ago
|
||
I was going to report this for other sites as well, but since this report exists, I've decided to add a comment here instead.
As I said, this occurs for other sites as well. Is the background used in those cases really a white image? I thought it is a defined solid color. And based on my assumptions, I was going to suggest that Firefox applies "readability backplating" only for images and not for solid colors. But if in such cases the background is an image with a solid (e.g. white) color, I guess there is not much that can be done to prevent this (at least not in an automated way).
And yes - Edge does that as well, unfortunately and I'm going to report it to the MS Edge development team.
|
|
Assignee | |
Comment 9•4 years ago
|
||
We can potentially always suppress the canvas (html / body) background-image... Wdyt Morgan?
|
||
Comment 10•4 years ago
|
||
Related: https://www.reddit.com/r/firefox/comments/f4h82s/v730_swing_and_miss_with_readability_backplate/. Maybe we can avoid the backplate for almost solid color backgrounds?
|
|
||
Comment 11•4 years ago
|
||
(In reply to Emilio Cobos Álvarez (:emilio) from comment #9)
We can potentially always suppress the canvas (html / body) background-image... Wdyt Morgan?
yeah I think this is a good idea, but wondering what we should do about the other cases that aren't <body> related (ie the sidebar in the reddit post :evilpie linked) that are still important
|
||
Comment 12•4 years ago
|
||
(Found this from reddit)
FWIW, there's also a in-tree web compat add-on that can do per-domain interventions. Maybe there could be a high contrast only interventions system, not sure that scales for this particular issue though.
https://searchfox.org/mozilla-central/source/browser/extensions/webcompat
|
|
||
Comment 13•4 years ago
|
||
(In reply to Tim Nguyen :ntim from comment #12)
(Found this from reddit)
FWIW, there's also a in-tree web compat add-on that can do per-domain interventions. Maybe there could be a high contrast only interventions system, not sure that scales for this particular issue though.
https://searchfox.org/mozilla-central/source/browser/extensions/webcompat
Yeah, this is something we're considering for the ebay case, depending on how wide-spread this issue is (though, right now there isn't an easy way to specific compat interventions that should happen in HCM; maybe if we get prefers-contrast enabled, we can go down this path! https://bugzilla.mozilla.org/show_bug.cgi?id=1506364)
|
|
Assignee | |
Comment 14•4 years ago
|
||
Let's give this a shot.
|
||
Updated•4 years ago
|
|
||
Comment 15•4 years ago
|
||
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0551e1798d61 Ignore background-image on canvas in high-contrast mode. r=morgan
|
|
||
Comment 16•4 years ago
|
||
(In reply to Morgan Reschenberg [:morgan] from comment #11)
other cases that aren't <body> related
Bug 1616440 for the top of Wikipedia articles.
|
|
Assignee | |
Comment 17•4 years ago
|
||
|
|
||
Comment 18•4 years ago
|
||
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1221e1369f08 Adjust some fuzzy values.
|
||
Comment 19•4 years ago
|
||
Backed out 2 changesets (Bug 1614921) for causing reftest failures at layout/reftests/high-contrast/backplate-bg-image-001.html
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=289642488&repo=autoland&lineNumber=14947
|
|
Assignee | |
Updated•4 years ago
|
|
|
||
Comment 20•4 years ago
|
||
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b75bfbd1de6e Ignore background-image on canvas in high-contrast mode. r=morgan
|
||
Comment 21•4 years ago
|
||
| bugherder | ||
|
||
Updated•4 years ago
|
|
||
Comment 23•4 years ago
|
||
Reproduced the issue using Firefox 75.0a1 (20200212205745) on Windows 10x64.
The issue is verified fixed with Firefox 75.0b7 (20200322132212) on Windows 10x64.
|
|
||
Updated•4 years ago
|
Description
•