1614923 - Disable the FOGotype

Status: RESOLVED FIXED

(Toolkit :: Telemetry, task, P1)

Description

[Chris H-C :chutten]

We've gotten what we wanted out of the FOGotype. Now it's time for it to go.

Rather than rip it out wholesale, let's start by just disabling it. We'll still need the Glean SDK in-tree in a moment, so it'd be a waste to unvendor it just to revendor it in a week.

Comment 1

[Jan-Erik Rediger [:janerik]]

Attachment: Bug 1614923 - Disable the FOGotype. r?chutten!

This removes calling the initializer on the fog crate.
It leaves everything else in tact, including:

• Leaves the fog crate in tree, including its dependencies such as glean-preview
• Leaves the "fogotype" feature on gkrust-shared in place, ensuring glean is still compiled on nightly
  • it's not used, so it should just get removed at link time
• Leaves the build config untouched (which sets the MOZ_FOGOTYPE definition)

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/52f930304a8f
Disable the FOGotype. r=chutten

Comment 3

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/52f930304a8f

Comment 4

[Marian Raiciof [:marauder]]

== Change summary for alert #24942 (as of Fri, 14 Feb 2020 12:08:36 GMT) ==

Improvements:

14% tp5n nonmain_startup_fileio windows7-32-shippable opt e10s stylo 3,362,132.92 -> 2,883,829.92
10% tp5n nonmain_startup_fileio windows7-32-shippable opt e10s stylo 3,317,720.83 -> 2,969,625.92

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=24942