1615021 - Update Verify failures on beta 74 during release promotion

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Rob Lemley [:rjl]]

We've got Update-Verify failures on all platforms with build2 that need to be addressed.

This is from a macOS update test, but other platforms are doing the same kind of thing:

[task 2020-02-12T16:06:32.101Z] Comparing source/Thunderbird.app with target/Thunderbird.app..
[task 2020-02-12T16:06:32.102Z] Directories only in source/Thunderbird.app:
[task 2020-02-12T16:06:32.102Z] Contents/Resources/distribution
[task 2020-02-12T16:06:32.102Z] Contents/Resources/distribution/extensions
[task 2020-02-12T16:06:32.102Z] Files only in source/Thunderbird.app:
[task 2020-02-12T16:06:32.102Z] Contents/Resources/distribution/extensions/{e2fda1a4-762b-4020-b5ad-a41df1933103}.xpi

Looking at removed-files, it's only attempting to remove an unpacked calendar, not one that is in .xpi form. The installs I have handy on my machine all have packed calendar extensions, not unpacked in the install directory. Were there older versions that unpacked?

I think the way to fix this is to include both the unpacked and xpi forms in removed-files.

Comment 1

[Geoff Lankow (:darktrojan)]

Once upon a time Lightning was unpacked before use, but I don't recall if it ever shipped that way. I think you're right, listing the XPI files in removed-files is the way to go.

Comment 2

[Rob Lemley [:rjl]]

Attachment: calendar_updater.patch

For beta 74

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a6e2519cc655
Add XPI form of calendar extension to removed-files. r=darktrojan DONTBUILD

Comment 4

[Rob Lemley [:rjl]]

Thunderbird 74.0b1:
https://hg.mozilla.org/releases/comm-beta/rev/4640b2ae5aca