Closed
Bug 1615056
Opened 4 years ago
Closed 4 years ago
Remove layout.css.webkit-appearance.enabled.
Categories
(Core :: CSS Parsing and Computation, defect, P3)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla75
Tracking | Status | |
---|---|---|
firefox75 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
Details
Attachments
(1 file)
No description provided.
Assignee | ||
Comment 1•4 years ago
|
||
I don't think we want to keep the ugly widget hacks forever. Let me know if
you'd rather keep the property behind a pref but I don't think there's a point
in doing that.
Updated•4 years ago
|
Priority: -- → P3
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/222723ab0b5b Remove layout.css.webkit-appearance.enabled. r=jwatt
Comment 3•4 years ago
|
||
Backed out changeset 222723ab0b5b (Bug 1615056) for bustages complaining about nsNativeThemeWin.cpp
Backout link: https://hg.mozilla.org/integration/autoland/rev/36de39298facc26dc85ac67584ec1cf7d748e2a5
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=289530799&repo=autoland&lineNumber=79376
[task 2020-02-19T14:02:46.856Z] 14:02:46 INFO - In file included from /builds/worker/workspace/build/src/widget/windows/nsNativeDragTarget.cpp:15:
[task 2020-02-19T14:02:46.856Z] 14:02:46 WARNING - /builds/worker/workspace/build/src/widget/windows/nsWindow.h:319:8: warning: 'const' type qualifier on return type has no effect [-Wignored-qualifiers]
[task 2020-02-19T14:02:46.856Z] 14:02:46 INFO - bool const DestroyCalled() { return mDestroyCalled; }
[task 2020-02-19T14:02:46.856Z] 14:02:46 INFO - ^~~~~~
[task 2020-02-19T14:02:46.856Z] 14:02:46 WARNING - /builds/worker/workspace/build/src/widget/windows/nsWindow.h:171:16: warning: 'Invalidate' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
[task 2020-02-19T14:02:46.856Z] 14:02:46 INFO - virtual void Invalidate(const LayoutDeviceIntRect& aRect);
[task 2020-02-19T14:02:46.856Z] 14:02:46 INFO - ^
[task 2020-02-19T14:02:46.856Z] 14:02:46 INFO - /builds/worker/workspace/build/src/obj-firefox/dist/include/nsIWidget.h:1263:16: note: overridden virtual function is here
[task 2020-02-19T14:02:46.856Z] 14:02:46 INFO - virtual void Invalidate(const LayoutDeviceIntRect& aRect) = 0;
[task 2020-02-19T14:02:46.857Z] 14:02:46 INFO - ^
[task 2020-02-19T14:02:46.857Z] 14:02:46 INFO - In file included from Unified_cpp_widget_windows2.cpp:29:
[task 2020-02-19T14:02:46.857Z] 14:02:46 INFO - In file included from /builds/worker/workspace/build/src/widget/windows/nsNativeDragTarget.cpp:15:
[task 2020-02-19T14:02:46.857Z] 14:02:46 WARNING - /builds/worker/workspace/build/src/widget/windows/nsWindow.h:541:8: warning: 'RequestFxrOutput' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
[task 2020-02-19T14:02:46.857Z] 14:02:46 INFO - void RequestFxrOutput();
[task 2020-02-19T14:02:46.857Z] 14:02:46 INFO - ^
[task 2020-02-19T14:02:46.857Z] 14:02:46 INFO - /builds/worker/workspace/build/src/obj-firefox/dist/include/nsIWidget.h:2106:16: note: overridden virtual function is here
[task 2020-02-19T14:02:46.857Z] 14:02:46 INFO - virtual void RequestFxrOutput() {
[task 2020-02-19T14:02:46.857Z] 14:02:46 INFO - ^
[task 2020-02-19T14:02:46.857Z] 14:02:46 INFO - In file included from Unified_cpp_widget_windows2.cpp:38:
[task 2020-02-19T14:02:46.859Z] 14:02:46 WARNING - /builds/worker/workspace/build/src/widget/windows/nsNativeThemeWin.cpp:2730:5: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
[task 2020-02-19T14:02:46.860Z] 14:02:46 INFO - case StyleAppearance::Button:
[task 2020-02-19T14:02:46.860Z] 14:02:46 INFO - ^
[task 2020-02-19T14:02:46.860Z] 14:02:46 INFO - /builds/worker/workspace/build/src/widget/windows/nsNativeThemeWin.cpp:2730:5: note: insert '[[fallthrough]];' to silence this warning
[task 2020-02-19T14:02:46.861Z] 14:02:46 INFO - case StyleAppearance::Button:
[task 2020-02-19T14:02:46.861Z] 14:02:46 INFO - ^
[task 2020-02-19T14:02:46.861Z] 14:02:46 INFO - [[fallthrough]];
[task 2020-02-19T14:02:46.861Z] 14:02:46 INFO - /builds/worker/workspace/build/src/widget/windows/nsNativeThemeWin.cpp:2730:5: note: insert 'break;' to avoid fall-through
[task 2020-02-19T14:02:46.862Z] 14:02:46 INFO - case StyleAppearance::Button:
[task 2020-02-19T14:02:46.862Z] 14:02:46 INFO - ^
[task 2020-02-19T14:02:46.862Z] 14:02:46 INFO - break;
[task 2020-02-19T14:02:46.862Z] 14:02:46 ERROR - /builds/worker/workspace/build/src/widget/windows/nsNativeThemeWin.cpp:3638:10: error: duplicate case value 'MenulistButton'
[task 2020-02-19T14:02:46.862Z] 14:02:46 INFO - case StyleAppearance::MenulistButton:
[task 2020-02-19T14:02:46.862Z] 14:02:46 INFO - ^
[task 2020-02-19T14:02:46.862Z] 14:02:46 INFO - /builds/worker/workspace/build/src/widget/windows/nsNativeThemeWin.cpp:3622:10: note: previous case defined here
[task 2020-02-19T14:02:46.863Z] 14:02:46 INFO - case StyleAppearance::MenulistButton:
[task 2020-02-19T14:02:46.863Z] 14:02:46 INFO - ^
[task 2020-02-19T14:02:46.864Z] 14:02:46 INFO - In file included from Unified_cpp_widget_windows2.cpp:65:
[task 2020-02-19T14:02:46.864Z] 14:02:46 INFO - In file included from /builds/worker/workspace/build/src/widget/windows/nsPrintSettingsServiceWin.cpp:9:
[task 2020-02-19T14:02:46.864Z] 14:02:46 WARNING - /builds/worker/workspace/build/src/widget/windows/nsPrintSettingsWin.h:30:20: warning: '_Clone' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
[task 2020-02-19T14:02:46.866Z] 14:02:46 INFO - virtual nsresult _Clone(nsIPrintSettings** _retval);
[task 2020-02-19T14:02:46.866Z] 14:02:46 INFO - ^
[task 2020-02-19T14:02:46.866Z] 14:02:46 INFO - /builds/worker/workspace/build/src/widget/nsPrintSettingsImpl.h:35:20: note: overridden virtual function is here
[task 2020-02-19T14:02:46.866Z] 14:02:46 INFO - virtual nsresult _Clone(nsIPrintSettings** _retval);
[task 2020-02-19T14:02:46.867Z] 14:02:46 INFO - ^
[task 2020-02-19T14:02:46.867Z] 14:02:46 INFO - In file included from Unified_cpp_widget_windows2.cpp:65:
[task 2020-02-19T14:02:46.868Z] 14:02:46 INFO - In file included from /builds/worker/workspace/build/src/widget/windows/nsPrintSettingsServiceWin.cpp:9:
[task 2020-02-19T14:02:46.868Z] 14:02:46 WARNING - /builds/worker/workspace/build/src/widget/windows/nsPrintSettingsWin.h:35:20: warning: '_Assign' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
[task 2020-02-19T14:02:46.869Z] 14:02:46 INFO - virtual nsresult _Assign(nsIPrintSettings* aPS);
[task 2020-02-19T14:02:46.869Z] 14:02:46 INFO - ^
[task 2020-02-19T14:02:46.869Z] 14:02:46 INFO - /builds/worker/workspace/build/src/widget/nsPrintSettingsImpl.h:36:20: note: overridden virtual function is here
[task 2020-02-19T14:02:46.871Z] 14:02:46 INFO - virtual nsresult _Assign(nsIPrintSettings* aPS);
[task 2020-02-19T14:02:46.871Z] 14:02:46 INFO - ^
[task 2020-02-19T14:02:46.872Z] 14:02:46 INFO - In file included from Unified_cpp_widget_windows2.cpp:119:
[task 2020-02-19T14:02:46.872Z] 14:02:46 INFO - In file included from /builds/worker/workspace/build/src/widget/windows/nsWindow.cpp:115:
[task 2020-02-19T14:02:46.873Z] 14:02:46 INFO - In file included from /builds/worker/workspace/build/src/obj-firefox/dist/include/nsWindowsDllInterceptor.h:29:
[task 2020-02-19T14:02:46.874Z] 14:02:46 INFO - In file included from /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/interceptor/PatcherDetour.h:22:
[task 2020-02-19T14:02:46.875Z] 14:02:46 WARNING - /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/interceptor/Trampoline.h:279:12: warning: moving a local object in a return statement prevents copy elision [-Wpessimizing-move]
[task 2020-02-19T14:02:46.876Z] 14:02:46 INFO - return std::move(result);
[task 2020-02-19T14:02:46.876Z] 14:02:46 INFO - ^
[task 2020-02-19T14:02:46.878Z] 14:02:46 INFO - /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/interceptor/Trampoline.h:279:12: note: remove std::move call here
[task 2020-02-19T14:02:46.878Z] 14:02:46 INFO - return std::move(result);
[task 2020-02-19T14:02:46.879Z] 14:02:46 INFO - ^~~~~~~~~~ ~
[task 2020-02-19T14:02:46.879Z] 14:02:46 INFO - In file included from Unified_cpp_widget_windows2.cpp:119:
[task 2020-02-19T14:02:46.880Z] 14:02:46 INFO - In file included from /builds/worker/workspace/build/src/widget/windows/nsWindow.cpp:165:
[task 2020-02-19T14:02:46.880Z] 14:02:46 INFO - In file included from /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/a11y/DocAccessible.h:11:
[task 2020-02-19T14:02:46.882Z] 14:02:46 WARNING - /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/a11y/HyperTextAccessibleWrap.h:32:3: warning: 'QueryInterface' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
[task 2020-02-19T14:02:46.882Z] 14:02:46 INFO - DECL_IUNKNOWN_INHERITED
[task 2020-02-19T14:02:46.883Z] 14:02:46 INFO - ^
[task 2020-02-19T14:02:46.884Z] 14:02:46 INFO - /builds/worker/workspace/build/src/obj-firefox/dist/include/IUnknownImpl.h:74:37: note: expanded from macro 'DECL_IUNKNOWN_INHERITED'
[task 2020-02-19T14:02:46.884Z] 14:02:46 INFO - virtual HRESULT STDMETHODCALLTYPE QueryInterface(REFIID, void**);
[task 2020-02-19T14:02:46.885Z] 14:02:46 INFO - ^
[task 2020-02-19T14:02:46.885Z] 14:02:46 INFO - /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/a11y/AccessibleWrap.h:45:16: note: overridden virtual function is here
[task 2020-02-19T14:02:46.886Z] 14:02:46 INFO - STDMETHODIMP QueryInterface(REFIID, void**) override;
[task 2020-02-19T14:02:46.887Z] 14:02:46 INFO - ^
[task 2020-02-19T14:02:46.887Z] 14:02:46 INFO - In file included from Unified_cpp_widget_windows2.cpp:119:
[task 2020-02-19T14:02:46.887Z] 14:02:46 INFO - In file included from /builds/worker/workspace/build/src/widget/windows/nsWindow.cpp:165:
[task 2020-02-19T14:02:46.888Z] 14:02:46 INFO - In file included from /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/a11y/DocAccessible.h:11:
[task 2020-02-19T14:02:46.889Z] 14:02:46 WARNING - /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/a11y/HyperTextAccessibleWrap.h:38:20: warning: 'HandleAccEvent' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
[task 2020-02-19T14:02:46.889Z] 14:02:46 INFO - virtual nsresult HandleAccEvent(AccEvent* aEvent);
[task 2020-02-19T14:02:46.889Z] 14:02:46 INFO - ^
[task 2020-02-19T14:02:46.890Z] 14:02:46 INFO - /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/a11y/AccessibleWrap.h:156:20: note: overridden virtual function is here
[task 2020-02-19T14:02:46.890Z] 14:02:46 INFO - virtual nsresult HandleAccEvent(AccEvent* aEvent) override;
[task 2020-02-19T14:02:46.891Z] 14:02:46 INFO - ^
[task 2020-02-19T14:02:46.891Z] 14:02:46 INFO - In file included from Unified_cpp_widget_windows2.cpp:119:
[task 2020-02-19T14:02:46.893Z] 14:02:46 WARNING - /builds/worker/workspace/build/src/widget/windows/nsWindow.cpp:510:37: warning: comparison of integers of different signs: 'DWORD' (aka 'unsigned long') and 'LONG' (aka 'long') [-Wsign-compare]
[task 2020-02-19T14:02:46.894Z] 14:02:46 INFO - static_cast<DWORD>(aLParam) != OBJID_CLIENT ||
[task 2020-02-19T14:02:46.894Z] 14:02:46 INFO - ~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~
[task 2020-02-19T14:02:46.895Z] 14:02:46 INFO - In file included from Unified_cpp_widget_windows2.cpp:137:
[task 2020-02-19T14:02:46.895Z] 14:02:46 WARNING - /builds/worker/workspace/build/src/widget/windows/nsWindowDbg.cpp:37:37: warning: format specifies type 'int' but the argument has type 'long' [-Wformat]
[task 2020-02-19T14:02:46.895Z] 14:02:46 INFO - ("%6d - 0x%04X %s\n", gEventCounter++, msg,
[task 2020-02-19T14:02:46.896Z] 14:02:46 INFO - ~~~ ^~~~~~~~~~~~~~~
[task 2020-02-19T14:02:46.897Z] 14:02:46 INFO - %6ld
[task 2020-02-19T14:02:46.897Z] 14:02:46 INFO - /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/Logging.h:286:56: note: expanded from macro 'MOZ_LOG'
[task 2020-02-19T14:02:46.897Z] 14:02:46 INFO - MOZ_LOG_EXPAND_ARGS _args); \
[task 2020-02-19T14:02:46.897Z] 14:02:46 INFO - ^~~~~
[task 2020-02-19T14:02:46.898Z] 14:02:46 INFO - /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/Logging.h:223:34: note: expanded from macro 'MOZ_LOG_EXPAND_ARGS'
[task 2020-02-19T14:02:46.899Z] 14:02:46 INFO - #define MOZ_LOG_EXPAND_ARGS(...) __VA_ARGS__
[task 2020-02-19T14:02:46.899Z] 14:02:46 INFO - ^~~~~~~~~~~
[task 2020-02-19T14:02:46.899Z] 14:02:46 INFO - 19 warnings and 1 error generated.
[task 2020-02-19T14:02:46.900Z] 14:02:46 INFO - /builds/worker/workspace/build/src/config/rules.mk:731: recipe for target 'Unified_cpp_widget_windows2.o' failed
[task 2020-02-19T14:02:46.900Z] 14:02:46 ERROR - make[4]: *** [Unified_cpp_widget_windows2.o] Error 1
[task 2020-02-19T14:02:46.900Z] 14:02:46 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/widget/windows'
[task 2020-02-19T14:02:46.902Z] 14:02:46 INFO - make[4]: *** Waiting for unfinished jobs....
[task 2020-02-19T14:02:46.902Z] 14:02:46 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/layout/style'
Flags: needinfo?(emilio)
Assignee | ||
Updated•4 years ago
|
Flags: needinfo?(emilio)
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a069393f7150 Remove layout.css.webkit-appearance.enabled. r=jwatt
Comment 5•4 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox75:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla75
You need to log in
before you can comment on or make changes to this bug.
Description
•