Closed Bug 1615057 Opened 5 years ago Closed 5 years ago

Respect author-specified padding when native theme is disabled

Categories

(Core :: Widget, defect, P1)

Product:
Core
Component:
Widget
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla75
Tracking Flags:
Tracking Status
firefox75 --- fixed

People

(Reporter: spohl, Assigned: spohl)

References

Details

Attachments

(1 file)

Bug 1615057: Respect author specified padding when native theme is disabled. r=mstange
47 bytes, text/x-phabricator-request
Details | Review

This was previously reviewed as part of bug 1381938. However, I removed it before landing because it seemed to trigger for more elements than expected when testing with [1][2]. Turns out that the reason why it didn't work properly was because the two pages specified padding of 0px for several elements - in other words, the fix worked properly.

[1] http://stephenhorlander.com/form-controls.html
[2] http://stephenhorlander.com/photon/UI-Controls-05/form-style-comparison.html

Pushed by spohl@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/810f66750d49 Respect author specified padding when native theme is disabled. r=mstange

https://hg.mozilla.org/mozilla-central/rev/810f66750d49

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox75: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla75
No longer blocks: 1381938
Blocks: 1615105
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: