Closed Bug 1615071 Opened 4 years ago Closed 4 years ago

Add Let's Encrypt's CT logs to certviewer

Categories

(Firefox :: Security, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 76
Tracking Status
firefox76 --- fixed

People

(Reporter: jcj, Assigned: luma, Mentored)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

https://searchfox.org/mozilla-central/source/toolkit/components/certviewer/content/ctlognames.js contains human-readable names for the certviewer. It does not contain Let's Encrypt's CT logs, instead showing a name of Unknown.

The Let's Encrypt Oak logs have keys listed here: https://letsencrypt.org/docs/ct-logs/

Example Let's Encrypt sites show one such log ID as E7:12:F2:B0:37:7E:1A:62:FB:8E:C9:0C:61:84:F1:EA:7B:37:CB:56:1D:11:26:5B:F3:E0:F3:4B:F2:41:54:6E.

Thanks JC!

Priority: -- → P2

You can find an example certificate here if you scroll all the way to the bottom (it's the certificate for letsencrypt.org).

The task is simply to copy over names and log ids from https://letsencrypt.org/docs/ct-logs/ into https://searchfox.org/mozilla-central/source/toolkit/components/certviewer/content/ctlognames.js, you'll have to replace the :: in the log ids and make them lowercase to match.

Mentor: jhofmann

Hi! May i work on this?

Hi Johannh I'll take care of this :)

(In reply to Jayati Shrivastava from comment #3)

Hi! May i work on this?

Hi Jayati, Johannh assigned me this bug in Matrix, now I ask her to sign this here too

Assignee: nobody → luma
Status: NEW → ASSIGNED

Yeah sorry I asked if Marinella wants to take this. I think you already have some things to work on Jayati, otherwise please let me know.

(In reply to Johann Hofmann [:johannh] from comment #2)

You can find an example certificate here if you scroll all the way to the bottom (it's the certificate for letsencrypt.org).

The task is simply to copy over names and log ids from https://letsencrypt.org/docs/ct-logs/ into https://searchfox.org/mozilla-central/source/toolkit/components/certviewer/content/ctlognames.js, you'll have to replace the :: in the log ids and make them lowercase to match.

Hi Johannh, I cannot open the link of the example certificate. Could you replace this? Thank you

Ok, no prob, I get it! :)

Should I insert also the Testflume names from Testing section, or only the Oak ones?

I guess it doesn't hurt to include the test ones? :)

(In reply to Johann Hofmann [:johannh] from comment #6)

Yeah sorry I asked if Marinella wants to take this. I think you already have some things to work on Jayati, otherwise please let me know.

Marinella can work on this. I'll poke some other bugs meanwhile :)

(In reply to Johann Hofmann [:johannh] from comment #10)

I guess it doesn't hurt to include the test ones? :)

Perfect it is that I want to know! :)

Depends on D66417

Pushed by jhofmann@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/62ab2cd02833
Add Let's Encrypt's CT logs to certviewer. r=johannh
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 76
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: