1615124 - undefined entity in messenger.xhtml Line Number 906, Column 3 <key id="openLightningKey" from lightning.dtd lightning.keys.event.showCalendar.key

Status: RESOLVED FIXED

(Calendar :: Build Config, defect)

Description

[Ben Bucksch (:BenB)]

Reproduction:

1. Linux
2. Build Thunderbird trunk 2020-02-12 with clobber
3. mach run

Actual result:

$ ../mach run
XML Parsing Error: undefined entity
Location: chrome://messenger/content/messenger.xhtml
Line Number 906, Column 3:  <key id="openLightningKey"

This comes from calendar/lightning/content/calendar-keys.inc.xhtml:

  <key id="openLightningKey"
       key="&lightning.keys.event.showCalendar.key;"
       modifiers="accel, shift"
       command="new_calendar_tab"/>

The entity is defined in calendar/locales/en-US/chrome/lightning/lightning.dtd:
<!ENTITY lightning.keys.event.showCalendar.key "C">

but apparently it's not referenced as DTD or cannot be loaded. Maybe missing from jar or something like that. I don't know, I haven't looked closely.

Expected result:

• Builds and starts

Importance:

• I cannot test my own code changes -> blocks development -> Blocker (by definition)

Regressed by:

• Integration of Lightning into Thunderbird

Comment 1

[Ben Bucksch (:BenB)]

This appears to be the first Lightning DTD entity used in Thunderbird, so it appears the Lightning locale doesn't build or load at all. Not specific to this entity.

Comment 2

[Ben Bucksch (:BenB)]

I've tested this with a clobber build (I've done 2 clobber builds, to be sure) and a fresh profile (1. mach run and 2. with a manually created new profile started with -no-remote -P).

Comment 3

[Ben Bucksch (:BenB)]

I found the reason: I did not have ac_add_options --enable-calendar in my .mozconfig. I didn't have it before, and according to Paul's posting on maildev, I thought that I must remove it now (but I didn't have it anyway). I needed to add it (which triggers yet another clobber), then Thunderbird builds and runs. It seems it's currently required to exist, and will soon be required to not exist.

Can you please just land bug 1612190? By landing bug 1608610 without bug 1612190, you broke the normal Thunderbird build :-( .

Comment 4

[Ben Bucksch (:BenB)]

Confirmed that the patch in bug 1612190 fixes this.

Comment 5

[Paul Morris [:pmorris]]

Fixed by bug 1612190.