1615130 - Potential uninitialized read in WebAudioUtils::LogToDeveloperConsole

Status: RESOLVED FIXED

(Core :: Web Audio, defect, P3)

Description

[Deian Stefan]

Semmle flagged uninitialized read of aLineNumber and aColumnNumber
https://searchfox.org/mozilla-central/source/dom/media/webaudio/WebAudioUtils.cpp#137-138

This looks like a true alert, but not really use if the JS context is every false here.

Comment 1

[Daniel Veditz [:dveditz]]

Printing garbage numbers on the console doesn't seem exploitable. The JS context might be null if this is called from C++

Comment 2

[Karl Tomlinson (:karlt)]

https://searchfox.org/mozilla-central/rev/a4be2fbe9bd4f405c91cc16e4e3a80400f5a9301/dom/media/webaudio/WebAudioUtils.cpp#137-138

Comment 3

[carnould]

Attachment: Bug 1615130 - Fix uninitialized data. r=padenot

Values are set to 0 by default rather than uninitialized. It is useful when AudioContext is null.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b912f803b3a8
Fix uninitialized data. r=padenot

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/b912f803b3a8