1615256 - Don't download miniconda on "./gradlew clean", if already downloaded

Status: RESOLVED FIXED

(Data Platform and Tools :: Glean: SDK, enhancement, P1)

Description

[Alessio Placitelli [:Dexter]]

Original Fenix issue

Steps to reproduce

1. Build Fenix with ./gradlew clean app:assembleGeckoNightlyDebug.
2. Rebuild with the same command.

Actual behavior

The build output shows:

> Task :app:Bootstrap_CONDA_'Miniconda3'
Downloading Miniconda3-4.5.11-Linux-x86_64.sh

on every incremental rebuild, and this step takes a while (~1 minute), adding significant latency to incremental rebuilds.

Expected behavior

Only download it the first time, not for incremental rebuilds.

Device information

• Android device: Moto G5
• Fenix version: recent master branch

Comment 1

[Jan-Erik Rediger [:janerik]]

The "clean" step in there will clear out everything, including the miniconda install bundled in the build directory, won't it?

Comment 2

[Alessio Placitelli [:Dexter]]

(In reply to Jan-Erik Rediger [:janerik] from comment #1)

The "clean" step in there will clear out everything, including the miniconda install bundled in the build directory, won't it?

Exactly (I pointed that out in the Fenix issue). However, Gradle is...well, gradle. There's still the Gradle cache that doesn't get invalidated unless you explicitly request to do that.

Maybe there's a way to catch the "invalidate cache" from the gradle script, so that we can simply skip downloaded unless invalidating. But that's well within the Gradle-hell land. And definitely post gradle plugin migration, IMHO.

Comment 3

[Michael Droettboom [:mdroettboom]]

including the miniconda install bundled in the build directory, won't it?

In this case, we install miniconda in the ~/.gradle/cache directory (so it can be shared between multiple components and projects using Glean). So it is somewhat surprising that clean removes it. I think this may be an artifact from when we used to install it in the build directory.

Removing this is probably enough to fix it. The Gradle plugin has a similar issue and a similarly easy fix.

Comment 4

[Michael Droettboom [:mdroettboom]]

It's easy enough to make clean not clear the miniconda environment. However, having cache invalidation clear it seems to be no longer supported according to this StackOverflow answer. I think we're still better off just removing it from clean, so I will file a PR for that.

Comment 5

[Michael Droettboom [:mdroettboom]]

Attachment: GitHub Pull Request