1615258 - [perfdocs] Add test manifest searchfox link to test descriptions

Status: RESOLVED FIXED

(Testing :: Performance, enhancement, P3)

Description

[Alexandru Ionescu (needinfo me) [:alexandrui]]

Add manifest seachfox link to test descriptions like:
Test name
- manifest link
Description.

Also insert indentation.

Comment 1

[Dave Hunt [:davehunt] [he/him] ⌚BST]

It might be safer to link to hg web. If we can identify the line of the manifest that defines the section then we could even include this in the link. For example: https://hg.mozilla.org/mozilla-central/file/f129d44e7878d7ccfd3a6876c5cf6a0dfd667d70/testing/raptor/raptor/tests/tp6/mobile/browsertime-tp6m.ini#l75

Comment 2

[Florin Bilt]

Do you think the revision number is relevant when generating the link that points to the related test in the manifest file?

Comment 3

[Greg Mierzwinski [:sparky]]

No, we should leave that out since it risks pointing the user to an outdated manifest - plus, if the manifest no longer exists, then the test would also cease to exist. Also, the revision number will need to be gathered in some way which could cause issues when we generate the documentation for verification in the perfdocs-verify task.

Comment 4

[Florin Bilt]

Attachment: Bug 1615258 - [perfdocs] Add test manifest searchfox link to test descriptions r?#perftest

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ace4b125b6e0
[perfdocs] Add test manifest searchfox link to test descriptions r=perftest-reviewers,sparky,jmaher,afinder

Comment 6

[Cristian Tuns]

Backed out for causing py3 failures

• Backout link
• Push with failures
• Failure Log
• Failure line: testing/mozbase/manifestparser/tests/test_manifestparser.py::TestManifestParser::test_edit_manifest TEST-UNEXPECTED-FAIL

Mozlint: https://treeherder.mozilla.org/logviewer?job_id=452666470&repo=autoland
tools/lint/test/test_perfdocs.py::test_perfdocs_framework_gatherers_urls[perfdocs] TEST-UNEXPECTED-FAIL

Comment 7

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cd1211fd6e7f
Backed out changeset ace4b125b6e0 for causing py3 failures in test_manifestparser.py CLOSED TREE

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8f90997050c1
[perfdocs] Add test manifest searchfox link to test descriptions r=perftest-reviewers,sparky,jmaher,afinder

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/8f90997050c1