Closed Bug 1615258 Opened 4 years ago Closed 22 days ago

[perfdocs] Add test manifest searchfox link to test descriptions

Categories

(Testing :: Performance, enhancement, P3)

enhancement

Tracking

(firefox126 fixed)

RESOLVED FIXED
126 Branch
Tracking Status
firefox126 --- fixed

People

(Reporter: alexandrui, Assigned: fbilt)

References

(Blocks 1 open bug, Regressed 1 open bug)

Details

(Whiteboard: [fxp])

Attachments

(1 file)

Add manifest seachfox link to test descriptions like:
Test name
- manifest link
Description.

Also insert indentation.

Summary: Add manifest seachfox link to test descriptions → Add test manifest seachfox link to test descriptions
Priority: -- → P3
Assignee: aionescu → nobody

It might be safer to link to hg web. If we can identify the line of the manifest that defines the section then we could even include this in the link. For example: https://hg.mozilla.org/mozilla-central/file/f129d44e7878d7ccfd3a6876c5cf6a0dfd667d70/testing/raptor/raptor/tests/tp6/mobile/browsertime-tp6m.ini#l75

Type: task → enhancement
Summary: Add test manifest seachfox link to test descriptions → [perfdocs] Add test manifest seachfox link to test descriptions
Version: Version 3 → unspecified
Severity: normal → S3
Whiteboard: [fxp]
Summary: [perfdocs] Add test manifest seachfox link to test descriptions → [perfdocs] Add test manifest searchfox link to test descriptions

Do you think the revision number is relevant when generating the link that points to the related test in the manifest file?

Flags: needinfo?(gmierz2)

No, we should leave that out since it risks pointing the user to an outdated manifest - plus, if the manifest no longer exists, then the test would also cease to exist. Also, the revision number will need to be gathered in some way which could cause issues when we generate the documentation for verification in the perfdocs-verify task.

Flags: needinfo?(gmierz2)
Assignee: nobody → fbilt
Status: NEW → ASSIGNED
Attachment #9392011 - Attachment description: WIP: Bug 1615258 - [perfdocs] Add test manifest searchfox link to test descriptions r?#perftest → Bug 1615258 - [perfdocs] Add test manifest searchfox link to test descriptions r?#perftest
Pushed by fbilt@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ace4b125b6e0
[perfdocs] Add test manifest searchfox link to test descriptions r=perftest-reviewers,sparky,jmaher,afinder

Backed out for causing py3 failures

Mozlint: https://treeherder.mozilla.org/logviewer?job_id=452666470&repo=autoland
tools/lint/test/test_perfdocs.py::test_perfdocs_framework_gatherers_urls[perfdocs] TEST-UNEXPECTED-FAIL

Flags: needinfo?(fbilt)
Backout by ctuns@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cd1211fd6e7f
Backed out changeset ace4b125b6e0 for causing py3 failures in test_manifestparser.py CLOSED TREE
Pushed by fbilt@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8f90997050c1
[perfdocs] Add test manifest searchfox link to test descriptions r=perftest-reviewers,sparky,jmaher,afinder
Flags: needinfo?(fbilt)
Status: ASSIGNED → RESOLVED
Closed: 22 days ago
Resolution: --- → FIXED
Target Milestone: --- → 126 Branch
Regressions: 1890589
Regressions: 1891193
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: