1615260 - Response for Runtime.callFunctionOn with returnbyValue shouldn't return value when it's not serializable

Status: RESOLVED FIXED

(Remote Protocol :: CDP, defect, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/02 - 10/06)]

See the difference between Chrome and Firefox when evaluating a non-serializable value:

Chrome:

  puppeteer:protocol SEND ► {"sessionId":"FDC196D1DD11938503876AB4D0C44BA5","method":"Runtime.callFunctionOn","params":{"functionDeclaration":"a => a\n//# sourceURL=__puppeteer_evaluation_script__\n","executionContextId":1,"arguments":[{"unserializableValue":"NaN"}],"returnByValue":true,"awaitPromise":true,"userGesture":true},"id":18} +1ms
  puppeteer:protocol ◀ RECV {"id":18,"result":{"result":{"type":"number","unserializableValue":"NaN","description":"NaN"}},"sessionId":"FDC196D1DD11938503876AB4D0C44BA5"} +1ms

Firefox:

puppeteer:protocol SEND ► {"sessionId":1,"method":"Runtime.callFunctionOn","params":{"functionDeclaration":"a => a\n//# sourceURL=__puppeteer_evaluation_script__\n","executionContextId":1,"arguments":[{"unserializableValue":"NaN"}],"returnByValue":true,"awaitPromise":true,"userGesture":true},"id":18} +2ms
  puppeteer:protocol ◀ RECV {"sessionId":1,"id":18,"result":{"result":{"value":null}}} +6ms

The problem here is that we always return a value property, and in cases like NaN a call to JSON.stringify()will returnnull` instead. As such we have to special-case certain values, and return immediately if the obj is of that type.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/02 - 10/06)]

Attachment: Bug 1615260 - [remote] Return correct properties for unserializable values in Runtime.callFunctionOn.

Values like NaN, Infinity, -Infinity are not serializable and have
to be returned via the unserializable property and not as value.

This patch also adds the type and description properties as
Puppeteer tests require, but leaves out support for -0 (bug 1615364)
and BigInt (bug 1615360).

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/afc658d2dd3a
[remote] Return correct properties for unserializable values in Runtime.callFunctionOn. r=remote-protocol-reviewers,maja_zf

Comment 4

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/afc658d2dd3a