Closed Bug 1615261 Opened 4 years ago Closed 4 years ago

Tab crashes on Print Preview exit on deviantart.com

Categories

(Core :: Print Preview, defect, P1)

75 Branch
defect

Tracking

()

VERIFIED FIXED
mozilla75
Tracking Status
firefox-esr68 --- unaffected
firefox73 --- unaffected
firefox74 + verified
firefox75 + verified

People

(Reporter: asoncutean, Assigned: emilio)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: crash, regression)

Crash Data

Attachments

(2 files)

Attached image tab_crash.png

[Affected versions]:

  • Fx 75.0a1 (2020-02-13)

[Affected platforms]:

  • Ubuntu 18.04
  • Windows 10

[Steps to reproduce]:

  1. Open https://www.deviantart.com/annewipf/art/Spring-798759311
  2. Enter in Print Preview
  3. Exit Print Preview

[Expected result]:

  • No issue is triggered by closing the Print Preview

[Actual result]:

  • Tab crashes

[Regression range]:

  • Not reproducible with Fx 74 (2020-01-27); looks like a recent regression, I will provide more conclusive details asap.

[Additional notes]:

  • No other page from devianart.com, that i’ve tried, crashed
  • With the link provided in steps reproducibility is 100%
Crash Signature: [@ mozilla::css::ImageLoader::UnloadImage]

[Tracking Requested - why for this release]: crash after exit print-priview

STR:

  1. Open https://www.deviantart.com/annewipf/art/Spring-798759311
  2. Enter in Print Preview
  3. Exit Print Preview
  4. If not crash, Resize browser

Actual results.
Tab immediately crash. OR sometimes content area is no longer resized and finally tab crash.

Regression Window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=fa233e2c081b14a5589f65e72769a259e0ad4fad&tochange=e3382fdd4f543e1177ba3b0f080d90905cdeb22f

Probably a pre-existing issue, just caught by that assert.

Assignee: nobody → emilio
Flags: needinfo?(emilio)

It's not clear to me this ever worked before either, I don't think the logic
before my patch was sound before.

But oh well. This should work, gotta add a test for it.

Flags: needinfo?(emilio)
Priority: -- → P3

Hello, the regressed build_date sets the bug in 2020-02-07, within version 74.0a1. I'll set the firefox74 flag to affected.

If the patch isn't risky, we could uplift it to beta as this is a new 74 regression.

Changing the priority to p1 as the bug is tracked by a release manager for the current beta.
See What Do You Triage for more information

Priority: P3 → P1
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5e057d52a531
Fix ImageLoader setup for animated images in print preview. r=tnikkel
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla75

Please nominate this for Beta uplift when you're comfortable doing so.

Flags: needinfo?(emilio)

Comment on attachment 9126477 [details]
Bug 1615261 - Fix ImageLoader setup for animated images in print preview. r=tnikkel

Beta/Release Uplift Approval Request

  • User impact if declined: Crashes in print preview in non-release builds. Potential badness in release.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: comment 0
  • List of other uplifts needed: none
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Simple patch that fixes the recently introduced setup for style images for animated images.
  • String changes made/needed: none
Flags: needinfo?(emilio)
Attachment #9126477 - Flags: approval-mozilla-beta?
Flags: qe-verify+

Comment on attachment 9126477 [details]
Bug 1615261 - Fix ImageLoader setup for animated images in print preview. r=tnikkel

Crash fix, 74 regression, uplift approved for beta, thanks.

Attachment #9126477 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
QA Whiteboard: [qa-triaged]
Has Regression Range: --- → yes
Has STR: --- → yes

I can no longer reproduce this crash with Fx 74.0b4 and Fx 75.0a1 (2020-02-16) with Windows 10 x64 and Ubuntu 18.04 x64.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: